Fix Select title hidden by Filtering(true) in apps init prompts#5114
Open
jamesbroadhead wants to merge 6 commits intomainfrom
Open
Fix Select title hidden by Filtering(true) in apps init prompts#5114jamesbroadhead wants to merge 6 commits intomainfrom
jamesbroadhead wants to merge 6 commits intomainfrom
Conversation
huh's Select.Filtering(true) immediately activates filter mode, which replaces the Title with a blank filter text input in titleView(). This meant the user never saw what resource they were being asked to select (e.g., "Select SQL Warehouse"). Remove Filtering(true) so the Title renders. Users can still press / to activate filtering (bound by default in huh's keymap). Update the description hint from "type to filter" to "press / to filter". Co-Authored-By: Claude Opus 4.6 <[email protected]>
Test that: - Title is visible in the initial render without Filtering(true) - Filtering(true) replaces the Title with a blank filter input (the bug) - Pressing '/' activates filtering and correctly filters options - Help text includes the filter hint Co-Authored-By: Claude Opus 4.6 <[email protected]>
…-resource-prompt-description
…pt-description # Conflicts: # libs/apps/prompt/prompt.go # libs/apps/prompt/prompt_test.go
The prompt_test.go file imports charmbracelet/x/ansi directly, so it should not be listed as indirect in go.mod. Co-authored-by: Isaac
3 tasks
Approval status: pending
|
- Add initForm helper that runs Init's command and feeds a WindowSizeMsg in. The previous f.Update(f.Init()) silently swallowed the cmd because Init returns tea.Cmd (a function), not a tea.Msg, so the form never laid out properly. - Share newWarehouseSelect between the title/visibility test and the filter activation test so the construction shape is asserted in one place. - Drop TestSelectTitleHiddenByFilteringTrue: it asserted the upstream huh bug, which means an upstream fix would fail CI here without any CLI regression. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
huh.Select.Filtering(true)immediately activates filter mode, which replaces the Title with a blank filter text input intitleView()— so the user never saw what resource they were selecting (e.g., "Select SQL Warehouse")Filtering(true)so the Title renders on initial display. Users can still press/to activate filtering (bound by default in huh's keymap)Affects both
promptFromListWithLabel(all resource pickers duringapps init) andPromptForAppSelection.Test plan
databricks apps initinteractively, select a feature, and verify the resource picker title (e.g., "Select SQL Warehouse") is now visible/activates filtering and typing filters the listEscexits filter mode and restores the title