Add more CREATE FOREIGN TABLE options

[imranzaheer612]

New options

• prefix
• keys_only
• revision
• key
• range_eng
• consistency

[if-loop69420]

Looks good. LGTM, if you've tested that everything works

[if-loop69420]

Please address these

[if-loop69420]

Could we change this to not have an '' before it? We're using the value and '' as a prefix suggests, that a value is not used

[if-loop69420]

The prefix option still doesn't work for me. It still yields things not in the prefix.

etcd_fdw=# CREATE FOREIGN TABLE t_etcd_table (key text, value text) SERVER etcd_server OPTIONS (prefix '/foo');
CREATE FOREIGN TABLE
etcd_fdw=# SELECT * FROM t_etcd_table ;
    key    | value
-----------+-------
 /foo/bar  | baz
 bar_new   | baz
 foo_new   | abc

Please fix these. Other than that LGTM

[imranzaheer612]

@if-loop69420 I am not able to reproduce the error you mentioned

etcd_fdw=# CREATE FOREIGN TABLE t_etcd_table (key text, value text) SERVER my_etcd_server OPTIONS (rowid_column 'key', prefix 'foo');
CREATE FOREIGN TABLE
etcd_fdw=# select * from t_etcd_table;
 key  | value 
------+-------
 foo  | 1
 foo1 | 1
 foo2 | 1
 foo3 | 1
 foo4 | 1
(5 rows)

[if-loop69420]

Looks good. Thank you. LGTM