fix being unable to ignore warnings in postcss-cascade-layers#1640
Merged
romainmenke merged 2 commits intocsstools:mainfrom Jun 26, 2025
Fox32:postcss-cascade-layers-ignore-warnings
Merged
fix being unable to ignore warnings in postcss-cascade-layers#1640romainmenke merged 2 commits intocsstools:mainfrom Fox32:postcss-cascade-layers-ignore-warnings
romainmenke merged 2 commits intocsstools:mainfrom
Fox32:postcss-cascade-layers-ignore-warnings
Conversation
romainmenke
reviewed
Jun 26, 2025
Contributor
Author
|
It was fun, test setup is nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tired to ignore the
onRevertLayerKeywordwarnings because they aren't relevant in my case, however setting it tofalsedid not disable them. Looking at the code I would have to disableonImportLayerRuleat the same time, however thenhasAnyLayeris not evaluated and the plugin exits early.I modified the code to evaluate both options individually and added a test for it. Including the updated files from the dist folder is correct, right?