RequestShare: Introduce the notion of a share request#194
RequestShare: Introduce the notion of a share request#194mickenordin merged 4 commits intodevelopfrom
Conversation
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
I went for a review of this new flow, hope I have understood the rationale, and of course all open for further comments.
Co-authored-by: Giuseppe Lo Presti <[email protected]>
mickenordin
force-pushed
the
kano-request
branch
from
1fb6942 to
2169dc9
Compare
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Looks good! One thing I wonder before merging: sender might be confused with the sender of the request-share, which actually is the recipient or shareWith. Should we name it differently, such as owner ? Or the fact that we have the recipient makes it clear enough after all? owner has its own drawbacks for co-owned / co-administered resources...
Even though neither of them is perfect, I think that your proposal is the less imperfect one, so I changed it to owner :) |
3 participants
No description provided.