fix(compactor): Fix flaky TestBlocksCleaner_ShouldRemoveBlocksOutside…#7486
Open
yeya24 wants to merge 1 commit intocortexproject:masterfrom
Open
fix(compactor): Fix flaky TestBlocksCleaner_ShouldRemoveBlocksOutside…#7486yeya24 wants to merge 1 commit intocortexproject:masterfrom
yeya24 wants to merge 1 commit intocortexproject:masterfrom
Conversation
…RetentionPeriod Switch from filesystem bucket to in-memory bucket in this test. The filesystem bucket's Upload is non-atomic (os.Create truncates, then io.Copy writes), creating a race window where the HeartBeat goroutine's write can be observed as an empty file by a concurrent read. The in-memory bucket's Upload is atomic (mutex-protected), eliminating the race. Signed-off-by: Ben Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…RetentionPeriod
Switch from filesystem bucket to in-memory bucket in this test. The filesystem bucket's Upload is non-atomic (os.Create truncates, then io.Copy writes), creating a race window where the HeartBeat goroutine's write can be observed as an empty file by a concurrent read. The in-memory bucket's Upload is atomic (mutex-protected), eliminating the race.
What this PR does:
Fix flaky test by switching to use an inmemory bucket to eliminate possible race condition when the visit marker is being uploaded.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags