fix: drop iam roles from github repository provider#53
fix: drop iam roles from github repository provider#53mtb-xt wants to merge 1 commit intocloudposse-terraform-components:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
📝 WalkthroughWalkthroughThe pull request removes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
|
Important Do not edit the Please update the Could you fix it @mtb-xt? 🙏 |
What
Remove the
iam_rolesaccount-map subcomponent from the GitHub repository component provider configuration.The AWS provider is still present because the component can read repository secret values from SSM Parameter Store and AWS Secrets Manager, but it now uses the ambient AWS credentials supplied by the runner/environment instead of resolving account-map roles.
Why
This component manages GitHub repositories, not AWS IAM resources. Pulling in
../account-map/modules/iam-rolesadds dynamic AWS identity/account-map data to otherwise GitHub-focused plans. In workflows that save a plan under one identity and apply under another, that identity-dependent data can make the saved plan differ from the apply-time plan even when the visible GitHub resource changes are the same.Migration note
Existing workspaces that have already applied this component with
module.iam_rolesin state may need a one-time state cleanup after upgrading.If OpenTofu/Terraform reports that it cannot read the schema for
cloudposse/awsutilswhile decoding old state, remove the obsolete module state entry before planning/applying this version, for example:terraform state rm 'module.iam_roles'That state entry only represented the provider/account-map helper path used for role resolution. The component no longer declares or uses it after this change.
Notes
Validation
terraform fmt -check src/providers.tfterraform -chdir=src init -backend=falseterraform -chdir=src validategit diff --checkSummary by CodeRabbit
Documentation
iam_rolesmodule from module documentation tables.Chores