Skip to content

Remove deprecated test buckets#5239

Draft
erikamov wants to merge 4 commits intomainfrom
mov/3711-remove-deprecated-test-buckets
Draft

Remove deprecated test buckets#5239
erikamov wants to merge 4 commits intomainfrom
mov/3711-remove-deprecated-test-buckets

Conversation

@erikamov
Copy link
Copy Markdown
Contributor

@erikamov erikamov commented May 5, 2026

Description

This PR removes deprecated test buckets from production. Those test buckets where replaced by Staging buckets.

  • test-calitp-elavon-raw
  • test-calitp-aggregator-scraper
  • dev-calitp-aggregator-scraper

Resolves #3711

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

  • Searched for references to the buckets to make sure they are not in use anywhere
  • Confirmed that the branch is empty
  • Tested removing with Terraform Plan.

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

@erikamov erikamov self-assigned this May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Terraform plan in iac/cal-itp-data-infra/gcs/us

Plan: 1 to add, 6 to change, 30 to destroy. Changes to Outputs.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+   create
!~  update in-place
-   destroy

Terraform will perform the following actions:

  # google_storage_bucket.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket" "tfer--dev-calitp-aggregator-scraper" {
-       default_event_based_hold    = false -> null
-       effective_labels            = {} -> null
-       enable_object_retention     = false -> null
-       force_destroy               = false -> null
-       id                          = "dev-calitp-aggregator-scraper" -> null
-       labels                      = {} -> null
-       location                    = "US-WEST2" -> null
-       name                        = "dev-calitp-aggregator-scraper" -> null
-       project                     = "cal-itp-data-infra" -> null
-       project_number              = 1005246706141 -> null
-       public_access_prevention    = "enforced" -> null
-       requester_pays              = false -> null
-       self_link                   = "https://www.googleapis.com/storage/v1/b/dev-calitp-aggregator-scraper" -> null
-       storage_class               = "STANDARD" -> null
-       terraform_labels            = {} -> null
-       time_created                = "2023-01-10T17:50:12.054Z" -> null
-       uniform_bucket_level_access = true -> null
-       updated                     = "2025-04-10T21:13:40.973Z" -> null
-       url                         = "gs://dev-calitp-aggregator-scraper" -> null

-       hierarchical_namespace {
-           enabled = false -> null
        }

-       lifecycle_rule {
-           action {
-               type          = "Delete" -> null
#                (1 unchanged attribute hidden)
            }
-           condition {
-               age                                     = 30 -> null
-               days_since_custom_time                  = 0 -> null
-               days_since_noncurrent_time              = 0 -> null
-               matches_prefix                          = [] -> null
-               matches_storage_class                   = [] -> null
-               matches_suffix                          = [] -> null
-               num_newer_versions                      = 0 -> null
-               send_age_if_zero                        = false -> null
-               send_days_since_custom_time_if_zero     = false -> null
-               send_days_since_noncurrent_time_if_zero = false -> null
-               send_num_newer_versions_if_zero         = false -> null
-               with_state                              = "ANY" -> null
#                (3 unchanged attributes hidden)
            }
        }

-       soft_delete_policy {
-           effective_time             = "2024-03-01T08:00:00.000Z" -> null
-           retention_duration_seconds = 604800 -> null
        }
    }

  # google_storage_bucket.tfer--rt-parsed-deprecated will be updated in-place
!~  resource "google_storage_bucket" "tfer--rt-parsed-deprecated" {
        id                          = "rt-parsed-deprecated"
        name                        = "rt-parsed-deprecated"
!~      terraform_labels            = {
+           "deprecated" = (known after apply)
        }
#        (16 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # google_storage_bucket.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket" "tfer--test-calitp-aggregator-scraper" {
-       default_event_based_hold    = false -> null
-       effective_labels            = {} -> null
-       enable_object_retention     = false -> null
-       force_destroy               = false -> null
-       id                          = "test-calitp-aggregator-scraper" -> null
-       labels                      = {} -> null
-       location                    = "US-WEST2" -> null
-       name                        = "test-calitp-aggregator-scraper" -> null
-       project                     = "cal-itp-data-infra" -> null
-       project_number              = 1005246706141 -> null
-       public_access_prevention    = "enforced" -> null
-       requester_pays              = false -> null
-       self_link                   = "https://www.googleapis.com/storage/v1/b/test-calitp-aggregator-scraper" -> null
-       storage_class               = "STANDARD" -> null
-       terraform_labels            = {} -> null
-       time_created                = "2023-01-11T19:37:11.949Z" -> null
-       uniform_bucket_level_access = true -> null
-       updated                     = "2025-04-10T21:13:40.406Z" -> null
-       url                         = "gs://test-calitp-aggregator-scraper" -> null

-       hierarchical_namespace {
-           enabled = false -> null
        }

-       lifecycle_rule {
-           action {
-               type          = "Delete" -> null
#                (1 unchanged attribute hidden)
            }
-           condition {
-               age                                     = 30 -> null
-               days_since_custom_time                  = 0 -> null
-               days_since_noncurrent_time              = 0 -> null
-               matches_prefix                          = [] -> null
-               matches_storage_class                   = [] -> null
-               matches_suffix                          = [] -> null
-               num_newer_versions                      = 0 -> null
-               send_age_if_zero                        = false -> null
-               send_days_since_custom_time_if_zero     = false -> null
-               send_days_since_noncurrent_time_if_zero = false -> null
-               send_num_newer_versions_if_zero         = false -> null
-               with_state                              = "ANY" -> null
#                (3 unchanged attributes hidden)
            }
        }

-       soft_delete_policy {
-           effective_time             = "2024-03-01T08:00:00.000Z" -> null
-           retention_duration_seconds = 604800 -> null
        }
    }

  # google_storage_bucket.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_bucket.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_bucket" "tfer--test-calitp-elavon" {
-       default_event_based_hold    = false -> null
-       effective_labels            = {} -> null
-       enable_object_retention     = false -> null
-       force_destroy               = false -> null
-       id                          = "test-calitp-elavon" -> null
-       labels                      = {} -> null
-       location                    = "US-WEST2" -> null
-       name                        = "test-calitp-elavon" -> null
-       project                     = "cal-itp-data-infra" -> null
-       project_number              = 1005246706141 -> null
-       public_access_prevention    = "enforced" -> null
-       requester_pays              = false -> null
-       self_link                   = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon" -> null
-       storage_class               = "STANDARD" -> null
-       terraform_labels            = {} -> null
-       time_created                = "2023-03-08T19:08:46.094Z" -> null
-       uniform_bucket_level_access = true -> null
-       updated                     = "2025-04-10T21:13:40.851Z" -> null
-       url                         = "gs://test-calitp-elavon" -> null

-       hierarchical_namespace {
-           enabled = false -> null
        }

-       lifecycle_rule {
-           action {
-               type          = "Delete" -> null
#                (1 unchanged attribute hidden)
            }
-           condition {
-               age                                     = 30 -> null
-               days_since_custom_time                  = 0 -> null
-               days_since_noncurrent_time              = 0 -> null
-               matches_prefix                          = [] -> null
-               matches_storage_class                   = [] -> null
-               matches_suffix                          = [] -> null
-               num_newer_versions                      = 0 -> null
-               send_age_if_zero                        = false -> null
-               send_days_since_custom_time_if_zero     = false -> null
-               send_days_since_noncurrent_time_if_zero = false -> null
-               send_num_newer_versions_if_zero         = false -> null
-               with_state                              = "ANY" -> null
#                (3 unchanged attributes hidden)
            }
        }

-       soft_delete_policy {
-           effective_time             = "2024-03-01T08:00:00.000Z" -> null
-           retention_duration_seconds = 604800 -> null
        }

-       versioning {
-           enabled = false -> null
        }
    }

  # google_storage_bucket.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_bucket.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_bucket" "tfer--test-calitp-elavon-parsed" {
-       default_event_based_hold    = false -> null
-       effective_labels            = {} -> null
-       enable_object_retention     = false -> null
-       force_destroy               = false -> null
-       id                          = "test-calitp-elavon-parsed" -> null
-       labels                      = {} -> null
-       location                    = "US-WEST2" -> null
-       name                        = "test-calitp-elavon-parsed" -> null
-       project                     = "cal-itp-data-infra" -> null
-       project_number              = 1005246706141 -> null
-       public_access_prevention    = "enforced" -> null
-       requester_pays              = false -> null
-       self_link                   = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon-parsed" -> null
-       storage_class               = "STANDARD" -> null
-       terraform_labels            = {} -> null
-       time_created                = "2023-04-07T17:06:22.168Z" -> null
-       uniform_bucket_level_access = true -> null
-       updated                     = "2025-04-10T21:13:40.925Z" -> null
-       url                         = "gs://test-calitp-elavon-parsed" -> null

-       hierarchical_namespace {
-           enabled = false -> null
        }

-       lifecycle_rule {
-           action {
-               type          = "Delete" -> null
#                (1 unchanged attribute hidden)
            }
-           condition {
-               age                                     = 30 -> null
-               days_since_custom_time                  = 0 -> null
-               days_since_noncurrent_time              = 0 -> null
-               matches_prefix                          = [] -> null
-               matches_storage_class                   = [] -> null
-               matches_suffix                          = [] -> null
-               num_newer_versions                      = 0 -> null
-               send_age_if_zero                        = false -> null
-               send_days_since_custom_time_if_zero     = false -> null
-               send_days_since_noncurrent_time_if_zero = false -> null
-               send_num_newer_versions_if_zero         = false -> null
-               with_state                              = "ANY" -> null
#                (3 unchanged attributes hidden)
            }
        }

-       soft_delete_policy {
-           effective_time             = "2024-03-01T08:00:00.000Z" -> null
-           retention_duration_seconds = 604800 -> null
        }
    }

  # google_storage_bucket.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_bucket.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_bucket" "tfer--test-calitp-elavon-raw" {
-       default_event_based_hold    = false -> null
-       effective_labels            = {} -> null
-       enable_object_retention     = false -> null
-       force_destroy               = false -> null
-       id                          = "test-calitp-elavon-raw" -> null
-       labels                      = {} -> null
-       location                    = "US-WEST2" -> null
-       name                        = "test-calitp-elavon-raw" -> null
-       project                     = "cal-itp-data-infra" -> null
-       project_number              = 1005246706141 -> null
-       public_access_prevention    = "enforced" -> null
-       requester_pays              = false -> null
-       self_link                   = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon-raw" -> null
-       storage_class               = "STANDARD" -> null
-       terraform_labels            = {} -> null
-       time_created                = "2023-03-10T21:47:28.107Z" -> null
-       uniform_bucket_level_access = true -> null
-       updated                     = "2025-04-10T21:13:41.226Z" -> null
-       url                         = "gs://test-calitp-elavon-raw" -> null

-       hierarchical_namespace {
-           enabled = false -> null
        }

-       lifecycle_rule {
-           action {
-               type          = "Delete" -> null
#                (1 unchanged attribute hidden)
            }
-           condition {
-               age                                     = 30 -> null
-               days_since_custom_time                  = 0 -> null
-               days_since_noncurrent_time              = 0 -> null
-               matches_prefix                          = [] -> null
-               matches_storage_class                   = [] -> null
-               matches_suffix                          = [] -> null
-               num_newer_versions                      = 0 -> null
-               send_age_if_zero                        = false -> null
-               send_days_since_custom_time_if_zero     = false -> null
-               send_days_since_noncurrent_time_if_zero = false -> null
-               send_num_newer_versions_if_zero         = false -> null
-               with_state                              = "ANY" -> null
#                (3 unchanged attributes hidden)
            }
        }

-       soft_delete_policy {
-           effective_time             = "2024-03-01T08:00:00.000Z" -> null
-           retention_duration_seconds = 604800 -> null
        }
    }

  # google_storage_bucket_acl.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_acl.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_acl" "tfer--dev-calitp-aggregator-scraper" {
-       bucket      = "dev-calitp-aggregator-scraper" -> null
-       id          = "dev-calitp-aggregator-scraper" -> null
-       role_entity = [] -> null
    }

  # google_storage_bucket_acl.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_acl.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_acl" "tfer--test-calitp-aggregator-scraper" {
-       bucket      = "test-calitp-aggregator-scraper" -> null
-       id          = "test-calitp-aggregator-scraper" -> null
-       role_entity = [] -> null
    }

  # google_storage_bucket_acl.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_bucket_acl.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_bucket_acl" "tfer--test-calitp-elavon" {
-       bucket      = "test-calitp-elavon" -> null
-       id          = "test-calitp-elavon" -> null
-       role_entity = [] -> null
    }

  # google_storage_bucket_acl.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_bucket_acl.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_bucket_acl" "tfer--test-calitp-elavon-parsed" {
-       bucket      = "test-calitp-elavon-parsed" -> null
-       id          = "test-calitp-elavon-parsed" -> null
-       role_entity = [] -> null
    }

  # google_storage_bucket_acl.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_bucket_acl.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_bucket_acl" "tfer--test-calitp-elavon-raw" {
-       bucket      = "test-calitp-elavon-raw" -> null
-       id          = "test-calitp-elavon-raw" -> null
-       role_entity = [] -> null
    }

  # google_storage_bucket_iam_binding.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_binding.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_binding" "tfer--dev-calitp-aggregator-scraper" {
-       bucket  = "b/dev-calitp-aggregator-scraper" -> null
-       etag    = "CAI=" -> null
-       id      = "dev-calitp-aggregator-scraper" -> null
-       members = [
-           "projectViewer:cal-itp-data-infra",
        ] -> null
-       role    = "roles/storage.legacyObjectReader" -> null
    }

  # google_storage_bucket_iam_binding.tfer--gtfs-data-test will be updated in-place
!~  resource "google_storage_bucket_iam_binding" "tfer--gtfs-data-test" {
        id      = "gtfs-data-test"
!~      members = [
-           "deleted:serviceAccount:[email protected]?uid=111080371999374643299",
+           "serviceAccount:[email protected]",
#            (3 unchanged elements hidden)
        ]
#        (3 unchanged attributes hidden)
    }

  # google_storage_bucket_iam_binding.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_binding.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_binding" "tfer--test-calitp-aggregator-scraper" {
-       bucket  = "b/test-calitp-aggregator-scraper" -> null
-       etag    = "CAI=" -> null
-       id      = "test-calitp-aggregator-scraper" -> null
-       members = [
-           "projectEditor:cal-itp-data-infra",
-           "projectOwner:cal-itp-data-infra",
        ] -> null
-       role    = "roles/storage.legacyBucketOwner" -> null
    }

  # google_storage_bucket_iam_binding.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_bucket_iam_binding.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_bucket_iam_binding" "tfer--test-calitp-elavon" {
-       bucket  = "b/test-calitp-elavon" -> null
-       etag    = "CAI=" -> null
-       id      = "test-calitp-elavon" -> null
-       members = [
-           "projectViewer:cal-itp-data-infra",
        ] -> null
-       role    = "roles/storage.legacyObjectReader" -> null
    }

  # google_storage_bucket_iam_binding.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_bucket_iam_binding.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_bucket_iam_binding" "tfer--test-calitp-elavon-parsed" {
-       bucket  = "b/test-calitp-elavon-parsed" -> null
-       etag    = "CAI=" -> null
-       id      = "test-calitp-elavon-parsed" -> null
-       members = [
-           "projectViewer:cal-itp-data-infra",
        ] -> null
-       role    = "roles/storage.legacyObjectReader" -> null
    }

  # google_storage_bucket_iam_binding.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_bucket_iam_binding.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_bucket_iam_binding" "tfer--test-calitp-elavon-raw" {
-       bucket  = "b/test-calitp-elavon-raw" -> null
-       etag    = "CAI=" -> null
-       id      = "test-calitp-elavon-raw" -> null
-       members = [
-           "projectEditor:cal-itp-data-infra",
-           "projectOwner:cal-itp-data-infra",
        ] -> null
-       role    = "roles/storage.legacyBucketOwner" -> null
    }

  # google_storage_bucket_iam_binding.tfer--test-calitp-gtfs-rt-raw will be updated in-place
!~  resource "google_storage_bucket_iam_binding" "tfer--test-calitp-gtfs-rt-raw" {
        id      = "test-calitp-gtfs-rt-raw"
!~      members = [
-           "deleted:serviceAccount:[email protected]?uid=111080371999374643299",
+           "serviceAccount:[email protected]",
#            (1 unchanged element hidden)
        ]
#        (3 unchanged attributes hidden)
    }

  # google_storage_bucket_iam_member.tfer--calitp-gtfs-schedule-validation will be created
+   resource "google_storage_bucket_iam_member" "tfer--calitp-gtfs-schedule-validation" {
+       bucket = "b/calitp-gtfs-schedule-validation"
+       etag   = (known after apply)
+       id     = (known after apply)
+       member = "serviceAccount:[email protected]"
+       role   = "roles/storage.objectCreator"
    }

  # google_storage_bucket_iam_member.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_member.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_member" "tfer--dev-calitp-aggregator-scraper" {
-       bucket = "b/dev-calitp-aggregator-scraper" -> null
-       etag   = "CAI=" -> null
-       id     = "dev-calitp-aggregator-scraper" -> null
-       member = "projectOwner:cal-itp-data-infra" -> null
-       role   = "roles/storage.legacyBucketOwner" -> null
    }

  # google_storage_bucket_iam_member.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_member.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_member" "tfer--test-calitp-aggregator-scraper" {
-       bucket = "b/test-calitp-aggregator-scraper" -> null
-       etag   = "CAI=" -> null
-       id     = "test-calitp-aggregator-scraper" -> null
-       member = "projectViewer:cal-itp-data-infra" -> null
-       role   = "roles/storage.legacyBucketReader" -> null
    }

  # google_storage_bucket_iam_member.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_bucket_iam_member.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_bucket_iam_member" "tfer--test-calitp-elavon" {
-       bucket = "b/test-calitp-elavon" -> null
-       etag   = "CAI=" -> null
-       id     = "test-calitp-elavon" -> null
-       member = "projectViewer:cal-itp-data-infra" -> null
-       role   = "roles/storage.legacyObjectReader" -> null
    }

  # google_storage_bucket_iam_member.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_bucket_iam_member.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_bucket_iam_member" "tfer--test-calitp-elavon-parsed" {
-       bucket = "b/test-calitp-elavon-parsed" -> null
-       etag   = "CAI=" -> null
-       id     = "test-calitp-elavon-parsed" -> null
-       member = "projectEditor:cal-itp-data-infra" -> null
-       role   = "roles/storage.legacyObjectOwner" -> null
    }

  # google_storage_bucket_iam_member.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_bucket_iam_member.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_bucket_iam_member" "tfer--test-calitp-elavon-raw" {
-       bucket = "b/test-calitp-elavon-raw" -> null
-       etag   = "CAI=" -> null
-       id     = "test-calitp-elavon-raw" -> null
-       member = "projectViewer:cal-itp-data-infra" -> null
-       role   = "roles/storage.legacyBucketReader" -> null
    }

  # google_storage_bucket_iam_policy.tfer--calitp-gtfs-schedule-validation will be updated in-place
!~  resource "google_storage_bucket_iam_policy" "tfer--calitp-gtfs-schedule-validation" {
        id          = "calitp-gtfs-schedule-validation"
!~      policy_data = jsonencode(
!~          {
!~              bindings = [
#                    (3 unchanged elements hidden)
                    {
                        members = [
                            "projectViewer:cal-itp-data-infra",
                        ]
                        role    = "roles/storage.legacyObjectReader"
                    },
!~                  {
!~                      members = [
!~                          "deleted:serviceAccount:[email protected]?uid=117956330948086473326" -> "serviceAccount:[email protected]",
                        ]
#                        (1 unchanged attribute hidden)
                    },
                ]
            }
        )
#        (2 unchanged attributes hidden)
    }

  # google_storage_bucket_iam_policy.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_policy.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_policy" "tfer--dev-calitp-aggregator-scraper" {
-       bucket      = "b/dev-calitp-aggregator-scraper" -> null
-       etag        = "CAI=" -> null
-       id          = "dev-calitp-aggregator-scraper" -> null
-       policy_data = jsonencode(
            {
-               bindings = [
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketReader"
                    },
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectReader"
                    },
                ]
            }
        ) -> null
    }

  # google_storage_bucket_iam_policy.tfer--gtfs-data-test will be updated in-place
!~  resource "google_storage_bucket_iam_policy" "tfer--gtfs-data-test" {
        id          = "gtfs-data-test"
!~      policy_data = jsonencode(
!~          {
!~              bindings = [
#                    (3 unchanged elements hidden)
                    {
                        members = [
                            "projectViewer:cal-itp-data-infra",
                        ]
                        role    = "roles/storage.legacyObjectReader"
                    },
!~                  {
!~                      members = [
                            "serviceAccount:[email protected]",
!~                          "deleted:serviceAccount:[email protected]?uid=111080371999374643299" -> "serviceAccount:[email protected]",
                            "serviceAccount:local-airflow-dev@cal-itp-data-infra-staging.iam.gserviceaccount.com",
#                            (1 unchanged element hidden)
                        ]
#                        (1 unchanged attribute hidden)
                    },
                    {
                        members = [
                            "serviceAccount:project-1005246706141@storage-transfer-service.iam.gserviceaccount.com",
                            "serviceAccount:project-473674835135@storage-transfer-service.iam.gserviceaccount.com",
                        ]
                        role    = "roles/storage.objectViewer"
                    },
                ]
            }
        )
#        (2 unchanged attributes hidden)
    }

  # google_storage_bucket_iam_policy.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_bucket_iam_policy.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_bucket_iam_policy" "tfer--test-calitp-aggregator-scraper" {
-       bucket      = "b/test-calitp-aggregator-scraper" -> null
-       etag        = "CAI=" -> null
-       id          = "test-calitp-aggregator-scraper" -> null
-       policy_data = jsonencode(
            {
-               bindings = [
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketReader"
                    },
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectReader"
                    },
                ]
            }
        ) -> null
    }

  # google_storage_bucket_iam_policy.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_bucket_iam_policy.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_bucket_iam_policy" "tfer--test-calitp-elavon" {
-       bucket      = "b/test-calitp-elavon" -> null
-       etag        = "CAI=" -> null
-       id          = "test-calitp-elavon" -> null
-       policy_data = jsonencode(
            {
-               bindings = [
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketReader"
                    },
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectReader"
                    },
                ]
            }
        ) -> null
    }

  # google_storage_bucket_iam_policy.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_bucket_iam_policy.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_bucket_iam_policy" "tfer--test-calitp-elavon-parsed" {
-       bucket      = "b/test-calitp-elavon-parsed" -> null
-       etag        = "CAI=" -> null
-       id          = "test-calitp-elavon-parsed" -> null
-       policy_data = jsonencode(
            {
-               bindings = [
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketReader"
                    },
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectReader"
                    },
                ]
            }
        ) -> null
    }

  # google_storage_bucket_iam_policy.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_bucket_iam_policy.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_bucket_iam_policy" "tfer--test-calitp-elavon-raw" {
-       bucket      = "b/test-calitp-elavon-raw" -> null
-       etag        = "CAI=" -> null
-       id          = "test-calitp-elavon-raw" -> null
-       policy_data = jsonencode(
            {
-               bindings = [
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyBucketReader"
                    },
-                   {
-                       members = [
-                           "projectEditor:cal-itp-data-infra",
-                           "projectOwner:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectOwner"
                    },
-                   {
-                       members = [
-                           "projectViewer:cal-itp-data-infra",
                        ]
-                       role    = "roles/storage.legacyObjectReader"
                    },
                ]
            }
        ) -> null
    }

  # google_storage_bucket_iam_policy.tfer--test-calitp-gtfs-rt-raw will be updated in-place
!~  resource "google_storage_bucket_iam_policy" "tfer--test-calitp-gtfs-rt-raw" {
        id          = "test-calitp-gtfs-rt-raw"
!~      policy_data = jsonencode(
!~          {
!~              bindings = [
#                    (3 unchanged elements hidden)
                    {
                        members = [
                            "projectViewer:cal-itp-data-infra",
                        ]
                        role    = "roles/storage.legacyObjectReader"
                    },
!~                  {
!~                      members = [
!~                          "deleted:serviceAccount:[email protected]?uid=111080371999374643299" -> "serviceAccount:[email protected]",
                            "serviceAccount:[email protected]",
                        ]
#                        (1 unchanged attribute hidden)
                    },
                ]
            }
        )
#        (2 unchanged attributes hidden)
    }

  # google_storage_default_object_acl.tfer--dev-calitp-aggregator-scraper will be destroyed
  # (because google_storage_default_object_acl.tfer--dev-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_default_object_acl" "tfer--dev-calitp-aggregator-scraper" {
-       bucket      = "dev-calitp-aggregator-scraper" -> null
-       id          = "dev-calitp-aggregator-scraper" -> null
-       role_entity = [] -> null
    }

  # google_storage_default_object_acl.tfer--test-calitp-aggregator-scraper will be destroyed
  # (because google_storage_default_object_acl.tfer--test-calitp-aggregator-scraper is not in configuration)
-   resource "google_storage_default_object_acl" "tfer--test-calitp-aggregator-scraper" {
-       bucket      = "test-calitp-aggregator-scraper" -> null
-       id          = "test-calitp-aggregator-scraper" -> null
-       role_entity = [] -> null
    }

  # google_storage_default_object_acl.tfer--test-calitp-elavon will be destroyed
  # (because google_storage_default_object_acl.tfer--test-calitp-elavon is not in configuration)
-   resource "google_storage_default_object_acl" "tfer--test-calitp-elavon" {
-       bucket      = "test-calitp-elavon" -> null
-       id          = "test-calitp-elavon" -> null
-       role_entity = [] -> null
    }

  # google_storage_default_object_acl.tfer--test-calitp-elavon-parsed will be destroyed
  # (because google_storage_default_object_acl.tfer--test-calitp-elavon-parsed is not in configuration)
-   resource "google_storage_default_object_acl" "tfer--test-calitp-elavon-parsed" {
-       bucket      = "test-calitp-elavon-parsed" -> null
-       id          = "test-calitp-elavon-parsed" -> null
-       role_entity = [] -> null
    }

  # google_storage_default_object_acl.tfer--test-calitp-elavon-raw will be destroyed
  # (because google_storage_default_object_acl.tfer--test-calitp-elavon-raw is not in configuration)
-   resource "google_storage_default_object_acl" "tfer--test-calitp-elavon-raw" {
-       bucket      = "test-calitp-elavon-raw" -> null
-       id          = "test-calitp-elavon-raw" -> null
-       role_entity = [] -> null
    }

Plan: 1 to add, 6 to change, 30 to destroy.

Changes to Outputs:
-   google_storage_bucket_acl_tfer--dev-calitp-aggregator-scraper_id                                           = "dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_acl_tfer--test-calitp-aggregator-scraper_id                                          = "test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_acl_tfer--test-calitp-elavon-parsed_id                                               = "test-calitp-elavon-parsed" -> null
-   google_storage_bucket_acl_tfer--test-calitp-elavon-raw_id                                                  = "test-calitp-elavon-raw" -> null
-   google_storage_bucket_acl_tfer--test-calitp-elavon_id                                                      = "test-calitp-elavon" -> null
-   google_storage_bucket_iam_binding_tfer--dev-calitp-aggregator-scraper_id                                   = "dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_binding_tfer--test-calitp-aggregator-scraper_id                                  = "test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_binding_tfer--test-calitp-elavon-parsed_id                                       = "test-calitp-elavon-parsed" -> null
-   google_storage_bucket_iam_binding_tfer--test-calitp-elavon-raw_id                                          = "test-calitp-elavon-raw" -> null
-   google_storage_bucket_iam_binding_tfer--test-calitp-elavon_id                                              = "test-calitp-elavon" -> null
!~  google_storage_bucket_iam_member_tfer--calitp-gtfs-schedule-validation_id                                  = "*******************************" -> (known after apply)
-   google_storage_bucket_iam_member_tfer--dev-calitp-aggregator-scraper_id                                    = "dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_member_tfer--test-calitp-aggregator-scraper_id                                   = "test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_member_tfer--test-calitp-elavon-parsed_id                                        = "test-calitp-elavon-parsed" -> null
-   google_storage_bucket_iam_member_tfer--test-calitp-elavon-raw_id                                           = "test-calitp-elavon-raw" -> null
-   google_storage_bucket_iam_member_tfer--test-calitp-elavon_id                                               = "test-calitp-elavon" -> null
-   google_storage_bucket_iam_policy_tfer--dev-calitp-aggregator-scraper_id                                    = "dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_policy_tfer--test-calitp-aggregator-scraper_id                                   = "test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_iam_policy_tfer--test-calitp-elavon-parsed_id                                        = "test-calitp-elavon-parsed" -> null
-   google_storage_bucket_iam_policy_tfer--test-calitp-elavon-raw_id                                           = "test-calitp-elavon-raw" -> null
-   google_storage_bucket_iam_policy_tfer--test-calitp-elavon_id                                               = "test-calitp-elavon" -> null
-   google_storage_bucket_tfer--dev-calitp-aggregator-scraper_name                                             = "dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_tfer--dev-calitp-aggregator-scraper_self_link                                        = "https://www.googleapis.com/storage/v1/b/dev-calitp-aggregator-scraper" -> null
-   google_storage_bucket_tfer--test-calitp-aggregator-scraper_name                                            = "test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_tfer--test-calitp-aggregator-scraper_self_link                                       = "https://www.googleapis.com/storage/v1/b/test-calitp-aggregator-scraper" -> null
-   google_storage_bucket_tfer--test-calitp-elavon-parsed_name                                                 = "test-calitp-elavon-parsed" -> null
-   google_storage_bucket_tfer--test-calitp-elavon-parsed_self_link                                            = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon-parsed" -> null
-   google_storage_bucket_tfer--test-calitp-elavon-raw_name                                                    = "test-calitp-elavon-raw" -> null
-   google_storage_bucket_tfer--test-calitp-elavon-raw_self_link                                               = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon-raw" -> null
-   google_storage_bucket_tfer--test-calitp-elavon_name                                                        = "test-calitp-elavon" -> null
-   google_storage_bucket_tfer--test-calitp-elavon_self_link                                                   = "https://www.googleapis.com/storage/v1/b/test-calitp-elavon" -> null
-   google_storage_default_object_acl_tfer--dev-calitp-aggregator-scraper_id                                   = "dev-calitp-aggregator-scraper" -> null
-   google_storage_default_object_acl_tfer--test-calitp-aggregator-scraper_id                                  = "test-calitp-aggregator-scraper" -> null
-   google_storage_default_object_acl_tfer--test-calitp-elavon-parsed_id                                       = "test-calitp-elavon-parsed" -> null
-   google_storage_default_object_acl_tfer--test-calitp-elavon-raw_id                                          = "test-calitp-elavon-raw" -> null
-   google_storage_default_object_acl_tfer--test-calitp-elavon_id                                              = "test-calitp-elavon" -> null

📝 Plan generated in Terraform Plan #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chore: Review production Buckets

1 participant