Remove tzset from shared_utils.rt_utils (#2029)#2030
Merged
Conversation
Contributor
Author
|
sorry for the pre-commit mistake! merging now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared_utils.rt_utilssets a timezone environment variable and usestime.tzset. This function is not defined on Windows, preventing local development with shared_utils, but does not seem to be necessary and could lead to unexpected behavior if users are not aware that the import is changing their timezone.Changes
time.tzsetfromshared_utils.rt_utilsTesting
uv run --group test pytestfrom the shared_utils directory and confirmed all tests passgtfs_digest/report_caltrans_district, received expected output