Skip to content

Commit c79eabc

Browse files
committed
test: correct existing mazerunner scenarios as per review feedback
1 parent 728c817 commit c79eabc

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

features/meta_data.feature

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,13 @@ Scenario: Sends a handled exception which includes custom metadata added in a no
1010
When I run spring boot "MetaDataScenario" with the defaults
1111
Then I should receive a request
1212
And the request is a valid for the error reporting API
13-
And the event "metaData.device.springVersion" is not null
14-
And the event "metaData.device.springBootVersion" is not null
1513
And the event "metaData.Custom.foo" equals "Hello World!"
1614

1715
Scenario: Sends a handled exception which includes custom metadata added in a notify callback for plain Spring app
1816
When I run plain Spring "MetaDataScenario" with the defaults
1917
Then I should receive a request
2018
And the request is a valid for the error reporting API
2119
And the event "metaData.Custom.foo" equals "Hello World!"
22-
And the event "metaData.device.springVersion" is not null
23-
And the event "metaData.device.springBootVersion" is null
2420

2521
Scenario: Test logback appender with meta data in the config file
2622
When I run "LogbackScenario" with logback config "meta_data_config.xml"

features/runtime_versions.feature

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,22 +7,22 @@ Scenario: Runtime versions included in Plain Java error
77
Then I should receive a request
88
And the request is valid for the error reporting API
99
And the payload field "events.0.device.runtimeVersions.javaType" ends with "Runtime Environment"
10-
And the payload field "events.0.device.runtimeVersions.javaVersion" starts with "1."
10+
And the payload field "events.0.device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
1111

1212
Scenario: Runtime versions included in Spring Framework error
1313
When I run plain Spring "HandledExceptionScenario" with the defaults
1414
Then I should receive a request
1515
And the request is valid for the error reporting API
1616
And the payload field "events.0.device.runtimeVersions.javaType" ends with "Runtime Environment"
17-
And the payload field "events.0.device.runtimeVersions.javaVersion" starts with "1."
17+
And the payload field "events.0.device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
1818
And the payload field "events.0.device.runtimeVersions.springFramework" matches the regex "(\d.)+"
1919

2020
Scenario: Runtime versions included in Spring Boot error
2121
When I run spring boot "HandledExceptionScenario" with the defaults
2222
Then I should receive a request
2323
And the request is valid for the error reporting API
2424
And the payload field "events.0.device.runtimeVersions.javaType" ends with "Runtime Environment"
25-
And the payload field "events.0.device.runtimeVersions.javaVersion" starts with "1."
25+
And the payload field "events.0.device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
2626
And the payload field "events.0.device.runtimeVersions.springFramework" matches the regex "(\d.)+"
2727
And the payload field "events.0.device.runtimeVersions.springBoot" matches the regex "(\d.)+"
2828

@@ -33,21 +33,21 @@ Scenario: Runtime versions included in Plain Java session
3333
Then I should receive a request
3434
And the request is valid for the session tracking API
3535
And the payload field "device.runtimeVersions.javaType" ends with "Runtime Environment"
36-
And the payload field "device.runtimeVersions.javaVersion" starts with "1."
36+
And the payload field "device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
3737

3838
Scenario: Runtime versions included in Spring Framework session
3939
When I run plain Spring "ManualSessionScenario" with the defaults
4040
Then I should receive a request
4141
And the request is valid for the session tracking API
4242
And the payload field "device.runtimeVersions.javaType" ends with "Runtime Environment"
43-
And the payload field "device.runtimeVersions.javaVersion" starts with "1."
43+
And the payload field "device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
4444
And the payload field "device.runtimeVersions.springFramework" matches the regex "(\d.)+"
4545

4646
Scenario: Runtime versions included in Spring Boot session
4747
When I run spring boot "ManualSessionScenario" with the defaults
4848
Then I should receive a request
4949
And the request is valid for the session tracking API
5050
And the payload field "device.runtimeVersions.javaType" ends with "Runtime Environment"
51-
And the payload field "device.runtimeVersions.javaVersion" starts with "1."
51+
And the payload field "device.runtimeVersions.javaVersion" matches the regex "(\d.)+"
5252
And the payload field "device.runtimeVersions.springFramework" matches the regex "(\d.)+"
5353
And the payload field "device.runtimeVersions.springBoot" matches the regex "(\d.)+"

0 commit comments

Comments
 (0)