Skip to content

Commit 728c817

Browse files
committed
test: pass existing tests
1 parent bb18702 commit 728c817

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

bugsnag-spring/src/main/java/com/bugsnag/BugsnagSpringConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import org.springframework.context.annotation.Import;
99
import org.springframework.core.SpringVersion;
1010

11-
import javax.annotation.PostConstruct;
1211
import java.util.Map;
12+
import javax.annotation.PostConstruct;
1313

1414
/**
1515
* Configuration to integrate Bugsnag with Spring.

bugsnag-spring/src/main/java/com/bugsnag/SpringBootConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
import org.springframework.context.annotation.Conditional;
1111
import org.springframework.context.annotation.Configuration;
1212

13-
import javax.servlet.ServletRequestListener;
1413
import java.util.Map;
14+
import javax.servlet.ServletRequestListener;
1515

1616
/**
1717
* If spring-boot is loaded, add configuration specific to Spring Boot

bugsnag-spring/src/test/java/com/bugsnag/SpringMvcTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,16 +157,18 @@ public void requestMetadataSetCorrectly() {
157157
}
158158

159159
@Test
160+
@SuppressWarnings("unchecked")
160161
public void springVersionSetCorrectly() {
161162
callRuntimeExceptionEndpoint();
162163

163164
Report report = verifyAndGetReport(delivery);
164165

165166
// Check that the Spring version is set as expected
166-
@SuppressWarnings(value = "unchecked") Map<String, Object> deviceMetadata =
167-
(Map<String, Object>) report.getMetaData().get("device");
168-
assertEquals(SpringVersion.getVersion(), deviceMetadata.get("springVersion"));
169-
assertEquals(SpringBootVersion.getVersion(), deviceMetadata.get("springBootVersion"));
167+
Map<String, Object> deviceMetadata = report.getDevice();
168+
Map<String, Object> runtimeVersions =
169+
(Map<String, Object>) deviceMetadata.get("runtimeVersions");
170+
assertEquals(SpringVersion.getVersion(), runtimeVersions.get("springFramework"));
171+
assertEquals(SpringBootVersion.getVersion(), runtimeVersions.get("springBoot"));
170172
}
171173

172174
@Test

bugsnag/src/test/java/com/bugsnag/SessionPayloadTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public void testJsonSerialisation() {
6363

6464
JsonNode device = rootNode.get("device");
6565
assertNotNull(device);
66-
assertEquals(3, device.size());
66+
assertEquals(4, device.size());
6767
}
6868

6969
}

0 commit comments

Comments
 (0)