Unregister only this module's type registration - #375
Merged
gennaroprota merged 1 commit intoAug 14, 2026
Conversation
The type registry is a multiset ordered by `std::type_info`, so the registrations two modules make for the same type compare equal. `type_unregister` looked entries up by that ordering and erased every match, which meant the first module to be unloaded took the other modules' registrations with it. Serialization of that type then failed in a module still running, with `unregistered_class`, since `get_derived_extended_type_info` no longer found anything. Remedy: erase the one entry which is this object, the way `key_unregister` has always done it for the registry keyed by export name. Fixes #325.
gennaroprota
force-pushed
the
fix/unregister-only-this-modules-type-registration
branch
from
August 13, 2026 13:35
46eee7c to
570601c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type registry is a multiset ordered by
std::type_info, so the registrations two modules make for the same type compare equal.type_unregisterlooked entries up by that ordering and erased every match, which meant the first module to be unloaded took the other modules' registrations with it. Serialization of that type then failed in a module still running, withunregistered_class, sinceget_derived_extended_type_infono longer found anything.Remedy: erase the one entry which is this object, the way
key_unregisterhas always done it for the registry keyed by export name.Fixes #325.