feat(git): persistent histogram of clone/fetch traffic per repository#292
Open
feat(git): persistent histogram of clone/fetch traffic per repository#292
Conversation
Contributor
Author
|
@codex review |
worstell
force-pushed
the
feat-git-repo-clone-histogram
branch
from
4e73b62 to
1005703
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12e84a01ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
worstell
force-pushed
the
feat-git-repo-clone-histogram
branch
from
1005703 to
a3d932b
Compare
Track per-repository pack-fetch counts in the metadata DB so callers can
identify the most frequently cloned repos served by the proxy.
The new RepoCounts type wraps a metadatadb.IntMap[string] keyed by
"<upstream-url>|<YYYY-MM-DD>". Each real fetch increments the bucket
for today (UTC). Daily bucketing makes time-windowed queries trivial
("top repos last 7 days") while a periodic reaper keeps the namespace
bounded by deleting entries older than 90 days.
Counted events:
- POST /git-upload-pack containing a protocol v1 payload, or v2
command=fetch.
- Excluded: GET /info/refs (every fetch's discovery probe, ls-remote,
and the proxy's own staleness check) and v2 command=ls-refs (the v2
equivalent of info/refs). RequestCountsAsFetch buffers and replays
the body; gzip Content-Encoding is decoded for inspection.
The increment runs after cloneManager.GetOrCreate has accepted the
upstream URL, so unauthenticated callers cannot bloat the keyspace
with arbitrary URLs.
The reaper is a no-op short-circuit when the namespace is empty,
returns the count of deleted entries, and only logs when something
was actually pruned.
Wiring:
- internal/metadatadb: new NamespaceProvider type for lazy resolution.
- internal/strategy/git: New/Register accept a NamespaceProvider; nil-safe.
- internal/config: Load takes a setMetadataStore callback so callers can
obtain the constructed Store before strategies are built.
- cmd/cachewd: declares an atomic.Pointer[metadatadb.Store] populated by
Load and read by the git strategy's namespace provider closure.
No external surface is added — the histogram is exposed through the
RepoCounts API for in-process consumers.
worstell
force-pushed
the
feat-git-repo-clone-histogram
branch
from
a3d932b to
ef5f4ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracks per-repository pack-fetch counts in the metadata DB so callers can identify the most frequently cloned repos served by the proxy. Exposes a
RepoCountsAPI; no HTTP surface.metadatadb.IntMap[string]keyed by<upstream-url>|<YYYY-MM-DD>. Daily buckets keep windowed queries trivial; a daily reaper drops entries older than 90 days, short-circuits on an empty namespace, returns the deleted count, and only logs when something was actually pruned.POST /git-upload-packand protocol v2command=fetch. Excluded:GET /info/refs(every fetch's discovery probe,ls-remote, and the proxy's own staleness check) and v2command=ls-refs(the v2 equivalent ofinfo/refs).RequestCountsAsFetchbuffers the body, decodes gzip when present, and replays it for downstream handlers.cloneManager.GetOrCreateaccepts the upstream URL, so unauthenticated callers cannot bloat the keyspace with arbitrary URLs.metadatadb.NamespaceProvider,git.New/Registeraccept it (nil-safe),config.Loadgains asetMetadataStorecallback, andcmd/cachewdholds the store in anatomic.Pointerso the provider closure can resolve the"git"namespace at strategy-construction time.