Skip to content

fix: anchor fetchThrowsOn regexes to avoid false positives on 2xx/3xx #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreahlert wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: anchor fetchThrowsOn regexes to avoid false positives on 2xx/3xx #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const config = {
attributes: "_, script, data-script",
defaultTransition: "all 500ms ease-in",
disableSelector: "[disable-scripting], [data-disable-scripting]",
fetchThrowsOn: [/4.*/, /5.*/],
fetchThrowsOn: [/^4/, /^5/],
hideShowStrategies: {},
logAll: false,
mutatingMethods: {
Expand Down
18 changes: 18 additions & 0 deletions test/commands/fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,24 @@ test.describe("the fetch command", () => {
await expect(find('div')).toHaveText("the body");
});

test("does not throw on 204 No Content", async ({html, find, page}) => {
await page.route('**/test', async (route) => {
await route.fulfill({ status: 204, body: '' });
});
await html("<div _='on click fetch /test then put \"ok\" into me'></div>");
await find('div').dispatchEvent('click');
await expect(find('div')).toHaveText("ok");
});

test("does not throw on 304 Not Modified", async ({html, find, page}) => {
await page.route('**/test', async (route) => {
await route.fulfill({ status: 304, body: '' });
});
await html("<div _='on click fetch /test then put \"ok\" into me'></div>");
await find('div').dispatchEvent('click');
await expect(find('div')).toHaveText("ok");
});

test("as response does not throw on 404", async ({html, find, page}) => {
await page.route('**/test', async (route) => {
await route.fulfill({ status: 404, body: 'not found' });
Expand Down