Enhance SQLServerColumn to support fixed numeric types and update tests#14
Merged
axellpadilla merged 1 commit intopatchedfrom Sep 30, 2025
Merged
Conversation
…ts for MONEY/SMALLMONEY behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances type handling and expansion logic for SQL Server columns, particularly around money-related types. The main changes include introducing a dedicated method for fixed-money types, refining numeric type checks, and updating the logic for type expansion to handle money and smallmoney types more accurately. The test suite is also expanded to cover these new scenarios.
Type handling improvements:
is_fixed_numerictosqlserver_column.pyto distinguish fixed-money types (money,smallmoney) from other numeric types.is_numberto include fixed-money types in its check, improving overall numeric type detection.is_numericto only matchnumericanddecimal, separating out money types for clearer logic.Type expansion logic:
can_expand_tomethod to allow expansion between numeric and fixed-money types, and to consider dtype changes as expansions when precision/scale are equal.Test coverage:
test_can_expand_to.pyto verify correct behavior for money, smallmoney, and numeric type expansions, including scenarios with and without feature flags.