-
-
Notifications
You must be signed in to change notification settings - Fork 167
fix: fix js_run_binary so tools executed with use_execroot_entry_point use exec-configuration runfiles
#2823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
longlho
wants to merge
1
commit into
aspect-build:main
from
longlho:fix-js-run-binary-exec-tool-runfiles
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| load("@bazel_lib//lib:testing.bzl", "assert_contains") | ||
| load("@bazel_lib//lib:transitions.bzl", "platform_transition_filegroup") | ||
| load("@bazel_skylib//rules:write_file.bzl", "write_file") | ||
| load("//js:defs.bzl", "js_binary", "js_run_binary") | ||
|
|
||
| config_setting( | ||
| name = "linux_arm64_target", | ||
| constraint_values = [ | ||
| "@platforms//os:linux", | ||
| "@platforms//cpu:arm64", | ||
| ], | ||
| ) | ||
|
|
||
| platform( | ||
| name = "linux_arm64", | ||
| constraint_values = [ | ||
| "@platforms//os:linux", | ||
| "@platforms//cpu:arm64", | ||
| ], | ||
| ) | ||
|
|
||
| write_file( | ||
| name = "write_tool", | ||
| out = "tool.mjs", | ||
| content = [ | ||
| """import { readFileSync } from "node:fs";""", | ||
| """import { dirname, join } from "node:path";""", | ||
| """import { fileURLToPath } from "node:url";""", | ||
| """const here = dirname(fileURLToPath(import.meta.url));""", | ||
| """console.log(readFileSync(join(here, "exec_config_marker.txt"), "utf8").trim());""", | ||
| ], | ||
| ) | ||
|
|
||
| write_file( | ||
| name = "write_exec_marker", | ||
| out = "exec_config_marker.txt", | ||
| content = ["exec-config-data"], | ||
| ) | ||
|
|
||
| write_file( | ||
| name = "write_target_marker", | ||
| out = "target_config_marker.txt", | ||
| content = ["target-config-data"], | ||
| ) | ||
|
|
||
| js_binary( | ||
| name = "tool", | ||
| data = select({ | ||
| ":linux_arm64_target": [":target_config_marker.txt"], | ||
| "//conditions:default": [":exec_config_marker.txt"], | ||
| }), | ||
| entry_point = "tool.mjs", | ||
| ) | ||
|
|
||
| js_run_binary( | ||
| name = "run_tool", | ||
| stdout = "run_tool.out", | ||
| tool = ":tool", | ||
| ) | ||
|
|
||
| platform_transition_filegroup( | ||
| name = "run_tool_linux_arm64", | ||
| testonly = True, | ||
| srcs = [":run_tool"], | ||
| target_platform = ":linux_arm64", | ||
| ) | ||
|
|
||
| assert_contains( | ||
| name = "run_tool_uses_exec_config_runfiles", | ||
| actual = ":run_tool_linux_arm64", | ||
| expected = "exec-config-data", | ||
| ) | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion assumes the execution platform is never
linux_arm64, but on ARM64 Linux runners the tool’s exec configuration will also match:linux_arm64_target, sotarget_config_marker.txtis selected and the expectedexec-config-datastring is wrong. That makes the new test fail on valid environments even whenjs_run_binaryis behaving correctly; the check needs to force a distinct exec platform (or make the marker selection architecture-agnostic) to avoid host-dependent failures.Useful? React with 👍 / 👎.