Fix "Stripes" preset span positions collapsing on repeated updateStops calls#127
Draft
Fix "Stripes" preset span positions collapsing on repeated updateStops calls#127
Conversation
✅ Deploy Preview for hd-gradients ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: argyleink <[email protected]>
…tions Co-authored-by: argyleink <[email protected]>
Copilot
AI
changed the title
[WIP] Fix clear issue with minimal changes
Fix "Stripes" preset span positions collapsing on repeated updateStops calls
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hadLinkedheuristic inupdateStopsincorrectly treated explicit span end-positions (e.g.0% 20%) as auto-linked pairs on any call after the first, collapsing them to0% 0%. This rendered the Stripes preset as solid black after the first user interaction with the overlay.Root cause
After the initial
updateStopspass,stop.autois set to the computed auto value (e.g.20for a stop at index 2). On the next call,position2 = '20'matchedprevAuto = 20, triggeringhadLinked = trueand overwritingposition2 ← position1 = '0':Fix
Guard the
prevAutobranch withp1Unset— a stop'sposition2should only be considered "linked to auto" whenposition1is also auto-managed:This preserves explicit spans like
#000 0% 20%across repeatedupdateStopscalls while keeping the redistribution linkage intact for fully auto-managed stop pairs.Tests
Added
src/lib/stripesIssue.test.tscovering idempotency of span positions across multipleupdateStopscalls and correct CSS output after re-normalization.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.