Text to vector refactoring#4375
Draft
nicolo-rinaldi wants to merge 9 commits intoapache:mainfrom
Draft
Conversation
…ture "Document enrichment with LLMs"
…nt enrichment module
…nt enrichment module
aruggero
suggested changes
Apr 29, 2026
nicolo-rinaldi
commented
Apr 29, 2026
| @ThreadSafe | ||
| public abstract class ManagedModelStore<M extends SolrLanguageModel> extends ManagedResource | ||
| implements ManagedResource.ChildResourceSupport { | ||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); |
Contributor
Author
There was a problem hiding this comment.
I kept it here due to the fact that most of the logic is in the function that are already in the abstract class
…nner class of ManagedLanguageModelStore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This refactoring is needed to prepare the code for the addition of the new module "Document Enrichment with LLMs" already in PR #4229, to avoid duplicated code as much as possible.
Solution
Abstract classes have been created for both the model and the store/rest packages. Also, renamed the exception to generalize across models. Implemented actual instances of the new abstract classes for the Text-to-vector module.
Claude code has been used as an assistant for coding this PR.
Tests
No tests have been added, since only interfaces and abstract classes have been developed.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.