feat: Add RowSelection::total_row_count - #10704
Open
haohuaijin wants to merge 1 commit into
Open
Conversation
Contributor
Author
haohuaijin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
RowSelectionexposesrow_count()(selected rows) andskipped_row_count()(skipped rows), but no way to get the total number of rows a selection spans. Callers that need the total (e.g. to validate a selection against a row group's row count, as #10702 does) must call both methods, which iterates a selector-backed selection twice and performs two popcounts on a mask-backed selection just to have them cancel out.What changes are included in this PR?
Adds
RowSelection::total_row_count(), which computes the total in a single pass:mask.len(), O(1) with no popcountAre these changes tested?
Yes, a unit test covers both backings plus the empty selection.
Are there any user-facing changes?
New public method
RowSelection::total_row_count(). No changes to existing APIs.