implement retain on metadata - #10695
Open
Rich-T-kid wants to merge 2 commits into
Open
Conversation
alamb
reviewed
Aug 15, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @Rich-T-kid -- I think this is very close -- I just have one question
Rich-T-kid
force-pushed
the
rich-t-kid/metadata-retain
branch
from
August 15, 2026 15:04
3459c41 to
abca0cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Metadata::retainto filter entries in place #10683.Rationale for this change
see #10683
What changes are included in this PR?
implements
retainon metadata. The underlying BTreeMap is allocation free unless theArcpointer is sharedAre these changes tested?
yes
Are there any user-facing changes?
yes, new
retainmethod on the metadata struct