refactor(cli): convert session subcommands to effectCmd#25483
Merged
kitlangton merged 1 commit intodevfrom May 2, 2026
Merged
Conversation
Convert session list + session delete from cmd() + bootstrap() to effectCmd + Effect.ensuring(store.dispose(ctx)). Session.Service yielded directly. The legacy try/catch around Session.get becomes Effect.catchCause + fail() (Session.get surfaces NotFoundError as a defect, not a typed E). Pager spawn stays inside Effect.promise. The parent SessionCommand stays on cmd() — group dispatcher only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Behavioral notes
Subagent purity audit: MOSTLY PURE WITH NOTES.
`db.ts` was considered next but skipped — none of its subcommands use bootstrap or any services (just spawns `sqlite3`, runs JSON migration). Converting would add an unnecessary instance load.
Test plan