fix(ui,app): allow context tooltip on touch and add mobile context tab#25370
Closed
fydiog wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(ui,app): allow context tooltip on touch and add mobile context tab#25370fydiog wants to merge 1 commit intoanomalyco:devfrom
fydiog wants to merge 1 commit intoanomalyco:devfrom
Conversation
…ab on mobile - Skip pointer-down arm on touch pointers in Tooltip so the tooltip can open when tapped. - Add a 'context' tab to the mobile viewport tab bar so narrow viewports can access the context details pane. - Render SessionContextTab inline when mobileTab === 'context'. - Adjust mobile tab widths from 1/2 to 1/3 to accommodate the new tab. Fixes anomalyco#10443
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10443
This PR addresses the issue where mobile/touch devices cannot access context details because our Tooltip captures and blocks pointer-down events (preventing Kobalte from opening on tap), and because the simplified mobile tab bar does not include a Context tab.
Changes:
Verified on local dev build with simulated touch viewport.