fix(app): avoid preview child MCP bootstraps#25244
Open
mattgenious wants to merge 8 commits intoanomalyco:devfrom
Open
fix(app): avoid preview child MCP bootstraps#25244mattgenious wants to merge 8 commits intoanomalyco:devfrom
mattgenious wants to merge 8 commits intoanomalyco:devfrom
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #25243
Type of change
What does this PR do?
Preview child stores are created with
bootstrap: falsewhen hovering/sidebar-previewing projects, but they still registered status queries for path, MCP, LSP, and providers. Those queries can hit directory-scoped backend routes and bootstrap the preview instance anyway.This PR keeps preview-only child stores from registering those status queries until the child is actually bootstrapped. Normal child store bootstrapping still enables the same queries, including when an existing preview child is later requested with bootstrap enabled.
How did you verify your code works?
bun test --preload ./happydom.ts ./src/context/global-sync/child-store.test.tsbun run test:unit ./src/context/global-sync/child-store.test.tsbun typecheckfrompackages/appbun turbo typecheckScreenshots / recordings
N/A. This is a non-visual behavior fix.
Checklist