fix(nix): remove stale packages/shared filter#24930
Open
jerome-benoit wants to merge 8 commits intoanomalyco:devfrom
Open
fix(nix): remove stale packages/shared filter#24930jerome-benoit wants to merge 8 commits intoanomalyco:devfrom
jerome-benoit wants to merge 8 commits intoanomalyco:devfrom
Conversation
The filter for packages/shared has been inert since the rename to packages/core (anomalyco#24309). Nix builds pass without it — core deps are resolved via hoisting from packages/opencode. Fixes anomalyco#24929
jerome-benoit
force-pushed
the
fix/nix-core-filter
branch
from
97561f6 to
dd49d37
Compare
jerome-benoit
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a stale Bun workspace filter in the Nix node_modules derivation after the packages/shared → packages/core rename, keeping the Nix build configuration aligned with the current workspace layout.
Changes:
- Delete the inert
--filter './packages/shared'entry fromnix/node_modules.nix.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24929
Type of change
What does this PR do?
Removes the stale
--filter './packages/shared'fromnix/node_modules.nix.packages/sharedwas renamed topackages/corein #24309 but the filter was left behind. It's inert — bun silently ignores filters for nonexistent packages, and the nix build has been passing since the rename because core's deps are hoisted throughpackages/opencode.How did you verify your code works?
Screenshots / recordings
N/A — cleanup, no UI change.
Checklist