Skip to content

fix(task): propagate parent session permissions to sub-agents#24293

Open
herjarsa wants to merge 1 commit intoanomalyco:devfrom
herjarsa:fix/task-inherit-parent-permissions
Open

fix(task): propagate parent session permissions to sub-agents#24293
herjarsa wants to merge 1 commit intoanomalyco:devfrom
herjarsa:fix/task-inherit-parent-permissions

Conversation

@herjarsa
Copy link
Copy Markdown

@herjarsa herjarsa commented Apr 25, 2026

Issue for this PR

Closes #6527

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

When spawning a sub-agent via the task tool, the child session was created with a blank permission array, losing any Plan mode restrictions (e.g. edit: deny) set on the parent. This allowed sub-agents to bypass the parent's read-only guardrails.

The child session now inherits the parent session's permission ruleset via Permission.merge() before applying its own sub-agent defaults. This ensures that restrictions like Plan mode (edit: deny) are preserved and cannot be bypassed by delegating to a sub-agent.

How did you verify your code works?

  • Ran bun typecheck in packages/opencode — no type errors in modified files
  • Added regression test in test/tool/task.test.ts that:
    1. Sets parent session to edit: deny
    2. Spawns a sub-agent via TaskTool
    3. Asserts the child session inherits edit: deny
    4. Asserts child still gets sub-agent defaults (todowrite: deny, task: deny)

Screenshots / recordings

N/A — not a UI change

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

When spawning a sub-agent via the task tool, the child session was created with a blank permission array, losing any Plan mode restrictions (e.g. edit: deny) set on the parent. This allowed sub-agents to bypass the parent's read-only guardrails.

The child session now merges the parent session's permission ruleset with its own (canTodo, canTask, primary_tools) to ensure inherited restrictions take precedence.

Fixes anomalyco#6527
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, here are potential related PRs:

Highly Related:

Related Context:

PR #23290 in particular seems very similar to the current PR #24293, both addressing preservation of parent permissions in task child sessions. You may want to verify if this is a duplicate or if they address different aspects of the same issue.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Apr 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRITICAL Security Issue/Bug] Plan mode restrictions bypassed when spawning sub-agents

1 participant