fix(tui): show skills in autocomplete dropdown (#22129)#23987
Open
PratikRai0101 wants to merge 5 commits intoanomalyco:devfrom
Open
fix(tui): show skills in autocomplete dropdown (#22129)#23987PratikRai0101 wants to merge 5 commits intoanomalyco:devfrom
PratikRai0101 wants to merge 5 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my searches, I found one potentially related PR: Related PR:
The current PR (#23987) is specifically about displaying skills in the TUI autocomplete dropdown, while the related PR might be addressing broader skills integration. However, they don't appear to be duplicates—they seem to be complementary features. The other result about file path autocomplete (#19391) is unrelated to skills. |
|
Looks decent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #22129
Type of change
What does this PR do?
Currently, skills do not appear in the TUI autocomplete suggestions, despite working perfectly in the web app. This was due to an explicit filter in
autocomplete.tsxthat skipped commands sourced from skills.This PR establishes UI parity between the TUI and the web app by:
if (serverCommand.source === "skill") continuefilter.:skillsuffix, matching the existing:mcpbehavior.How did you verify your code works?
diffto ensure the filter was cleanly removed.mcpandskillstring appends without syntax errors.Screenshots / recordings
N/A (TUI UI logic fix)
Checklist