fix: correct adaptive TUI theme luminance calculation#23917
Open
Klassikcat wants to merge 1 commit intoanomalyco:devfrom
Open
fix: correct adaptive TUI theme luminance calculation#23917Klassikcat wants to merge 1 commit intoanomalyco:devfrom
Klassikcat wants to merge 1 commit intoanomalyco:devfrom
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
related issue: anomalyco#23810
Klassikcat
force-pushed
the
fix/tui-adaptive-theme-luminance
branch
from
d7b8f6f to
6cdf29b
Compare
Author
|
@adamdotdevin force-pushed this branch to track the latest dev, since dev itself was force-pushed. Also tested, and can confirm it also works in 1.14.22. |
Author
|
@adamdotdevin Brightness detection was moved into OpenTUI in I'll close the PR and issue after updates opencode's OpenTUI dep to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23810
Type of change
What does this PR do?
/ 255from TUI adaptive theme luminance calculation inpackages/opencode/src/cli/cmd/tui/util/terminal.tsRGBAchannel values correctly so light terminals resolve to the light themeHow did you verify your code works?
Screenshots / recordings
Before
After
Checklist
If you do not follow this template your PR will be automatically rejected.