fix(mcp): stop OAuth callback server after authentication completes#23567
Closed
hchangjae wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(mcp): stop OAuth callback server after authentication completes#23567hchangjae wants to merge 1 commit intoanomalyco:devfrom
hchangjae wants to merge 1 commit intoanomalyco:devfrom
Conversation
552c126 to
ed62476
Compare
ed62476 to
cfcdb47
Compare
Author
|
Recreating with cleaner commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23562
Type of change
What does this PR do?
The OAuth callback server (port 19876) stays running after
authenticate()completes. When multiple TUI instances are running, the first instance holds the port and subsequent instances can't receive their own OAuth callbacks — their state is registered in their own process-localpendingAuthsMap, but the callback arrives at the first instance's server wherependingStates=[], resulting in CSRF errors.This adds
stopIfIdle()toMcpOAuthCallbackthat stops the server only when no pending auth flows remain, and calls it afterauthenticate()resolves (both success and state-mismatch paths). This is safe for concurrent auth flows — the server only stops when all pending auths are resolved.How did you verify your code works?
stopIfIdle()only callsstop()whenpendingAuths.size === 0ensureRunning()→ auth flow →stopIfIdle()→ port releasedauthenticate()to ensure cleanup on both success and erroroauth-callback.test.tstests useMcpOAuthCallback.stop()inafterEach— same patternChecklist