-
Notifications
You must be signed in to change notification settings - Fork 17.9k
fix: rewrite inappropriate advice to use ls command in example dialogues in system prompt #23135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 8 commits
705a5af
b0ae211
aefdf56
b9fc226
b64357d
b668220
2c1da32
a507acb
103e346
7442eeb
ab86dba
4ddcb01
75813dc
eb08494
db1b27e
f9acd74
2b06228
914a9e0
1941c95
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,12 +34,12 @@ assistant: Yes | |
|
|
||
| <example> | ||
| user: what command should I run to list files in the current directory? | ||
| assistant: ls | ||
| assistant: Use the read tool. | ||
| </example> | ||
|
|
||
| <example> | ||
| user: what command should I run to watch files in the current directory? | ||
| assistant: [use the ls tool to list the files in the current directory, then read docs/commands in the relevant file to find out how to watch files] | ||
| assistant: Use read to inspect files in the current directory, then read docs/commands in the relevant file to find out how to watch files. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think list the works still
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But there is no |
||
| npm run dev | ||
| </example> | ||
|
|
||
|
|
@@ -50,7 +50,7 @@ assistant: 150000 | |
|
|
||
| <example> | ||
| user: what files are in the directory src/? | ||
| assistant: [runs ls and sees foo.c, bar.c, baz.c] | ||
| assistant: [tool_call: read for absolute_path '/path/to/project/src', reports seeing foo.c, bar.c, baz.c] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reads src/ and sees |
||
| user: which file contains the implementation of foo? | ||
| assistant: src/foo.c | ||
| </example> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,7 @@ model: true | |
|
|
||
| <example> | ||
| user: list files here. | ||
| model: [tool_call: ls for path '/path/to/project'] | ||
| model: [tool_call: read for absolute_path '/path/to/project'] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need to be so specific it doesnt have to be absolute |
||
| </example> | ||
|
|
||
| <example> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,12 +26,12 @@ assistant: Yes | |
|
|
||
| <example> | ||
| user: what command should I run to list files in the current directory? | ||
| assistant: ls | ||
| assistant: Use the read tool. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bash tool's description advises not to use ls for exploratory purposes, so I thought it made sense. If you prefer ls, we can stick with that, though. |
||
| </example> | ||
|
|
||
| <example> | ||
| user: what command should I run to watch files in the current directory? | ||
| assistant: [use the ls tool to list the files in the current directory, then read docs/commands in the relevant file to find out how to watch files] | ||
| assistant: Use read to inspect files in the current directory, then read docs/commands in the relevant file to find out how to watch files. | ||
| npm run dev | ||
| </example> | ||
|
|
||
|
|
@@ -42,7 +42,7 @@ assistant: 150000 | |
|
|
||
| <example> | ||
| user: what files are in the directory src/? | ||
| assistant: [runs ls and sees foo.c, bar.c, baz.c] | ||
| assistant: [tool_call: read for absolute_path '/path/to/project/src', reports seeing foo.c, bar.c, baz.c] | ||
| user: which file contains the implementation of foo? | ||
| assistant: src/foo.c | ||
| </example> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait now that im reading this, the change doesnt make any sense at all haha why did we edit this at all? It should stay ls
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted. Made sense to me though, since bash tool's description says not to use ls for exploratory purposes?