Skip to content

fix(app): resume sessions in desktop app#6

Closed
anduimagui wants to merge 1 commit intoandrew/session-start-hook-basefrom
andrew/desktop-session-resume
Closed

fix(app): resume sessions in desktop app#6
anduimagui wants to merge 1 commit intoandrew/session-start-hook-basefrom
andrew/desktop-session-resume

Conversation

@anduimagui
Copy link
Copy Markdown
Owner

Summary

  • wire the app session route through the existing session resume lifecycle so desktop resumes existing sessions when reopening them
  • skip the first resume call for brand-new sessions and fresh forks so only true reopen flows trigger resume
  • add focused unit coverage for the shared app resume helper

Verification

  • bun test src/pages/session/session-resume.test.ts (blocked in this checkout because packages/app/happydom.ts imports missing @happy-dom/global-registrator)
  • bun typecheck in packages/app (blocked in this checkout by existing workspace dependency resolution issues)

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5a66445c-8084-4737-a07e-1911fa3aa5f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch andrew/desktop-session-resume

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Copy Markdown

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions
Copy link
Copy Markdown

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants