emit: nest pytrace track under TK_THREAD for collapsible rendering#60
Merged
anakryiko merged 1 commit intoanakryiko:masterfrom Apr 22, 2026
Merged
emit: nest pytrace track under TK_THREAD for collapsible rendering#60anakryiko merged 1 commit intoanakryiko:masterfrom
anakryiko merged 1 commit intoanakryiko:masterfrom
Conversation
The pytrace per-thread track was parented on TK_THREAD_META. While that is the semantically correct anchor for a thread's per-tid metadata, trace_processor treats META as a thread-metadata source rather than a slice track, so children with parent_uuid=META render as floating siblings of the kernel thread row instead of nested under it -- the "collapsible child row" behavior is lost in the UI. Move parent_uuid to TK_THREAD (the kernel event track), matching the TIMER track pattern from 3e7a877 ("emit: move timer events to a separate non-merged TIMER child track"). MERGE_NONE still keeps the row from being absorbed into the parent by Perfetto's BY_TRACK_NAME default. Result restored: pytrace appears as a collapsible nested child of the kernel thread row, hidden when the thread row is collapsed. Signed-off-by: Patrick Lu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pytrace per-thread track was parented on TK_THREAD_META. While that is the semantically correct anchor for a thread's per-tid metadata, trace_processor treats META as a thread-metadata source rather than a slice track, so children with parent_uuid=META render as floating siblings of the kernel thread row instead of nested under it -- the "collapsible child row" behavior is lost in the UI.
Move parent_uuid to TK_THREAD (the kernel event track), matching the TIMER track pattern from 3e7a877 ("emit: move timer events to a separate non-merged TIMER child track"). MERGE_NONE still keeps the row from being absorbed into the parent by Perfetto's BY_TRACK_NAME default.
Result restored: pytrace appears as a collapsible nested child of the kernel thread row, hidden when the thread row is collapsed.