feat: add no-new-wrappers#106
Open
SukkaW wants to merge 1 commit intoaladdin-add:masterfrom
Open
Conversation
Owner
Generally, I like to avoid it if possible. Have you seen such usage in real code? |
Contributor
Author
Let's search on GitHub real quick:
So apparently, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds autofix for the
no-new-wrappersrule:Note that the autofix does change the behavior of the original code; the right-hand value becomes a primitive value instead of an object wrapper. But in most cases, the auto-fixed code is desired. And if anyone does really need the original behavior, they should not enable this rule in the first place.
I'd appreciate it if you tag my PR w/
hacktoberfest-accepted!