fix(PdfList): remove redundant flex wrapper in bullet variant to fix wrapped-text overlap#104
Draft
fix(PdfList): remove redundant flex wrapper in bullet variant to fix wrapped-text overlap#104
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…prevent row overlap on wrapped text Agent-Logs-Url: https://github.com/akii09/pdfx/sessions/cff39600-7fcb-41da-9e8e-56ff987131e0 Co-authored-by: akii09 <[email protected]>
Copilot
AI
changed the title
[WIP] Fix overlapping bullet rows in PdfList rendering
fix(PdfList): remove redundant flex wrapper in bullet variant to fix wrapped-text overlap
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the bullet variant,
PDFText(already styled withflex: 1viaitemText) was wrapped in an extra<View style={{ flex: 1 }}>. This doubleflex: 1nesting triggers a known Yoga/@react-pdf/renderermeasurement bug where multi-lineTextheight is underestimated, causing subsequent bullet rows to overlap.Changes
list.tsx— Remove the intermediate<View style={{ flex: 1 }}>inrenderBulletItem;PDFTextis now a direct sibling of the dot marker, matching the layout pattern ofnumbered,checklist, andiconvariants:public/r/list.json— Registry JSON updated to reflect the same fix.list.test.tsx— Added tests for bullet variant with long wrapping text and nested children.