fix(ci): pin hf-xet<1.5 to fix model download failures#9203
fix(ci): pin hf-xet<1.5 to fix model download failures#9203VincyZhang wants to merge 1 commit intoai-dynamo:mainfrom
Conversation
hf-xet 1.5.0 (released 2026-05-06) deprecated and broke the hf_xet.download_files() API that huggingface_hub's snapshot_download() relies on internally. This causes all tests requiring model pre-download to fail with: RuntimeError: Failed to pre-download required Hugging Face models: hf_xet.download_files() is deprecated. Use XetSession().new_file_download_group().start_download_file() instead. Pin hf-xet<1.5 until huggingface_hub releases a compatible version that uses the new XetSession API. Signed-off-by: Zhang, Wenxin <[email protected]> Signed-off-by: VincyZhang <[email protected]>
|
👋 Hi VincyZhang! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughThe test requirements file pins the ChangesTest Dependency Pin
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
container/deps/requirements.test.txt (1)
19-20: ⚡ Quick winConsider tracking the pin removal with a GitHub issue.
Since this pin is temporary and should be removed once huggingface_hub supports the new XetSession API, consider creating a GitHub issue to track this future work. You could then reference it in the comment (e.g.,
# ... new XetSession API, see GH-XXXX).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@container/deps/requirements.test.txt` around lines 19 - 20, The requirements pin for "hf-xet<1.5" is temporary; create a GitHub issue to track removal once huggingface_hub supports the new XetSession API and update the inline comment next to the hf-xet<1.5 entry to reference that issue (e.g., "# For faster model downloads (pin <1.5 until huggingface_hub adapts to new XetSession API, see GH-XXXX)"), so future maintainers can find the follow-up work easily.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@container/deps/requirements.test.txt`:
- Around line 19-20: The requirements pin for "hf-xet<1.5" is temporary; create
a GitHub issue to track removal once huggingface_hub supports the new XetSession
API and update the inline comment next to the hf-xet<1.5 entry to reference that
issue (e.g., "# For faster model downloads (pin <1.5 until huggingface_hub
adapts to new XetSession API, see GH-XXXX)"), so future maintainers can find the
follow-up work easily.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f6d1f8f8-d7ef-4f5a-8bd5-57c870942acd
📒 Files selected for processing (1)
container/deps/requirements.test.txt
Problem
hf-xet 1.5.0 (released 2026-05-06) deprecated the
hf_xet.download_files()API thathuggingface_hub'ssnapshot_download()relies on internally. This causes all tests requiring model pre-download to fail with:Affected models: Qwen/Qwen2-VL-2B-Instruct, Qwen/Qwen3-0.6B, Qwen/Qwen2.5-VL-7B-Instruct, deepseek-ai/deepseek-llm-7b-base
Result: 31 test errors (all from fixture
predownload_modelsintests/conftest.py:389)Root Cause
hf-xetis unpinned incontainer/deps/requirements.test.txt. The newly released 1.5.0 broke backward compatibility with currenthuggingface_hubby converting a deprecation warning into a hard error.Fix
Pin
hf-xet<1.5untilhuggingface_hubreleases a version compatible with the newXetSessionAPI.Verification
pip install hf-xet<1.5 && python -c "from huggingface_hub import snapshot_download; snapshot_download('Qwen/Qwen3-0.6B', ignore_patterns=['*.safetensors'])"succeedsSummary by CodeRabbit