[pull] main from nodejs:main#175
Merged
pull[bot] merged 4 commits intoadamlaska:mainfrom Aug 15, 2025
Merged
Conversation
* feat: add eol page Co-Authored-By: Aviv Keller <[email protected]> * Update Modal.tsx Signed-off-by: Claudio Wunder <[email protected]> * expand and do not reuse i18n keys this helps our features be more portable * add one more i18n key * add footer to article layout * Update apps/site/components/EOL/Table.tsx Signed-off-by: Brian Muenzenmeyer <[email protected]> * cleanup unused classnames * simplify Table * normalize endOfLife vs eol * Apply suggestions from code review Co-authored-by: Joyee Cheung <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]> * add back in the release schedule link i think it is important to give people breadcrumbs like this * small grammar / tense / capitalization changes * Update apps/site/pages/en/eol.mdx Co-authored-by: Darshan Sen <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> * increase gap between vulnerability chips * make all translation strings long-form per feedback, this helps with static analysis. this scope included code not introduced in this PR * document translation key retrieval * rename variable * move CTAs up * chore: button variants, and updated eol page; removed translated previous-releases (outdated pages) * rename EOLModal/index per standard * rename components per docs and patterns * chore: design improvements * chore: tiny mobile improvement * chore: apply suggestions * chore: apply text suggestions * chore: balance the buttons * fix a11y issue on mdx rendering * chore: make it rain tm * Update vulnerabilities.mjs Co-authored-by: Copilot <[email protected]> Signed-off-by: Aviv Keller <[email protected]> * apply aviv"s suggestions - manually added as the redirect also needed a locale AFAIK * types and constants cleanup * fix import * more types cleanup * one final type lint actually ran locally. this instance is still suffering from some wonky husky problems * move link below buttons * move URL to constants * rename variable * tighten up UnknownSeverity types * format after refactor * memoize calls * simplify translation call * apply suggestion * apply linter * refator vulnerability grouping, add unit tests * avoid passing modal via frontmatter * generify modal props * move checks into children components * pass all vulns to children * fixup! * no modal provider * rename ref to url * fix type * use proper import specifier * tweak memo per review * destructure and cleanup. net, more lines of code, shrug * move key after fragment introduced fixes warning * change herodevs link to be a direct anchor, with no event listener from next * use rich translation for EOLAlertBox * chore: recommendation under Signed-off-by: Claudio Wunder <[email protected]> * Update apps/site/components/EOL/VulnerabilityChips/Chip/index.tsx Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]> * use filtered vulnerabilities * add space * use consistent modern looping * chore: cleanup, refactor + fixes * fix: tests --------- Signed-off-by: Claudio Wunder <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]> Signed-off-by: Aviv Keller <[email protected]> Co-authored-by: Aviv Keller <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Joyee Cheung <[email protected]> Co-authored-by: Darshan Sen <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Copilot <[email protected]>
* chore: synced translations from crowdin * chore: automated format of translated files Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Crowdin Bot <[email protected]> Co-authored-by: github-merge-queue <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )