Merge pull request #17 from YassinLokhat/16-fix-code-scanning-alert---workflow-does-not-contain-permissions

16 fix code scanning alert   workflow does not contain permissions

Author: YassinLokhat

.github/workflows/dotnet.yml

@@ -25,3 +25,8 @@ jobs:
       run: dotnet build --no-restore
     - name: Test
       run: dotnet test --no-build --verbosity normal
+
+permissions:
+  contents: read
+  issues: write
+  pull-requests: write

Core/Public/Utils/CryptographyCenter.cs

@@ -281,7 +281,7 @@ private string _decryptAes(string source, string[] passwords)
       private string _encryptRsa(string source, RSACryptoServiceProvider csp)
       {
          byte[] bytesPlainTextData = Encoding.Unicode.GetBytes(source);
-         byte[] bytesCypherText = csp.Encrypt(bytesPlainTextData, false);
+         byte[] bytesCypherText = csp.Encrypt(bytesPlainTextData, true);
 
          source = Convert.ToBase64String(bytesCypherText);
 
@@ -293,7 +293,7 @@ private string _decryptRsa(string source, int level, RSACryptoServiceProvider cs
          try
          {
             byte[] bytesCypherText = Convert.FromBase64String(source);
-            byte[] bytesPlainTextData = csp.Decrypt(bytesCypherText, false);
+            byte[] bytesPlainTextData = csp.Decrypt(bytesCypherText, true);
 
             return Encoding.Unicode.GetString(bytesPlainTextData);
          }

UnitTests/UnitTestsHelper.cs

@@ -1,5 +1,6 @@
 using FluentAssertions;
 using System.Runtime.CompilerServices;
+using System.Security.Cryptography;
 using Upsilon.Apps.PassKey.Core.Public.Enums;
 using Upsilon.Apps.PassKey.Core.Public.Interfaces;
 using Upsilon.Apps.PassKey.Core.Public.Utils;
@@ -85,7 +86,14 @@ public static void ClearTestEnvironment([CallerMemberName] string username = "")
 
       public static string GetUsername([CallerMemberName] string username = "") => username;
 
-      private static Random _getRandom() => new((int)DateTime.Now.Ticks);
+      private static RandomNumberGenerator _randomNumberGenerator => RandomNumberGenerator.Create();
+      private static Random _getRandom()
+      {
+         byte[] byteSeed = new byte[4];
+         _randomNumberGenerator.GetBytes(byteSeed);
+         int seed = BitConverter.ToInt32(byteSeed, 0);
+         return new Random(seed);
+      }
 
       public static string[] GetRandomStringArray(int count = 0)
       {
@@ -125,12 +133,7 @@ public static string GetRandomString(int min = 10, int max = 0)
 
       public static int GetRandomInt(int max) => GetRandomInt(0, max);
 
-      public static int GetRandomInt(int min, int max)
-      {
-         Random random = _getRandom();
-
-         return random.Next(min, max);
-      }
+      public static int GetRandomInt(int min, int max) => _getRandom().Next(min, max);
 
       public static void LastLogsShouldMatch(IDatabase database, string[] expectedLogs)
       {