Fix Insecure randomness

YassinLokhat · YassinLokhat · commit 77e73049305b · 2025-02-12T08:04:25.000+03:00
diff --git a/UnitTests/UnitTestsHelper.cs b/UnitTests/UnitTestsHelper.cs
@@ -89,10 +89,10 @@ public static void ClearTestEnvironment([CallerMemberName] string username = "")
       private static RandomNumberGenerator _randomNumberGenerator => RandomNumberGenerator.Create();
       private static Random _getRandom()
       {
-         byte[] randomNumber = new byte[4];
-         _randomNumberGenerator.GetBytes(randomNumber);
-         int value = BitConverter.ToInt32(randomNumber, 0);
-         return new Random(value);
+         byte[] byteSeed = new byte[4];
+         _randomNumberGenerator.GetBytes(byteSeed);
+         int seed = BitConverter.ToInt32(byteSeed, 0);
+         return new Random(seed);
       }
 
       public static string[] GetRandomStringArray(int count = 0)

Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,10 @@ public static void ClearTestEnvironment([CallerMemberName] string username = "")`
`89`	`89`	`private static RandomNumberGenerator _randomNumberGenerator => RandomNumberGenerator.Create();`
`90`	`90`	`private static Random _getRandom()`
`91`	`91`	`{`
`92`		`- byte[] randomNumber = new byte[4];`
`93`		`- _randomNumberGenerator.GetBytes(randomNumber);`
`94`		`- int value = BitConverter.ToInt32(randomNumber, 0);`
`95`		`- return new Random(value);`
	`92`	`+ byte[] byteSeed = new byte[4];`
	`93`	`+ _randomNumberGenerator.GetBytes(byteSeed);`
	`94`	`+ int seed = BitConverter.ToInt32(byteSeed, 0);`
	`95`	`+ return new Random(seed);`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`public static string[] GetRandomStringArray(int count = 0)`