Skip to content

Tests: Add REST API user creation email notification tests.#8672

Open
himanshupathak95 wants to merge 12 commits intoWordPress:trunkfrom
himanshupathak95:add/40477-unit-tests
Open

Tests: Add REST API user creation email notification tests.#8672
himanshupathak95 wants to merge 12 commits intoWordPress:trunkfrom
himanshupathak95:add/40477-unit-tests

Conversation

@himanshupathak95
Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/40477

This PR adds unit tests verifying email notifications are sent when creating users through the REST API. Tests cover:

  • Default admin notification behavior
  • Filter override capability via rest_wp_user_created_notification
  • Multi-recipient notifications when using 'both' parameter

Follows the implementation from #8572 by @nikunj8866.

@himanshupathak95 himanshupathak95 marked this pull request as ready for review April 9, 2025 21:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95, johnjamesjacoby, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95
Copy link
Copy Markdown
Author

The tests fail only in the multisite tests since, in those environments, we also need Super Admin privileges to create users. I will update the tests accordingly.

Comment thread src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php Outdated
Comment thread src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php Outdated
Copy link
Copy Markdown
Contributor

@JJJ JJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments...

Comment thread src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php Outdated
Comment thread src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php Outdated
@himanshupathak95
Copy link
Copy Markdown
Author

I don't see why the performance test must fail here, definitely unrelated to the changes in the PR.

Comment thread src/wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants