Tidy up _doing_it_wrong() within wp_unique_id_from_values().#8570
Tidy up _doing_it_wrong() within wp_unique_id_from_values().#8570peterwilsoncc wants to merge 3 commits intoWordPress:trunkfrom
_doing_it_wrong() within wp_unique_id_from_values().#8570Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
Good catch, @peterwilsoncc. This change looks good.
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
I think this works. Thanks @peterwilsoncc
| __( 'The $data argument must not be empty.' ), | ||
| gettype( $data ) | ||
| ), | ||
| // translators: $data` is the parameter name and must not be translated. |
There was a problem hiding this comment.
Why "`" is added after $data variable?
3 participants
A little tidy up of the DIW call within
wp_unique_id_from_values():Trac ticket: https://core.trac.wordpress.org/ticket/62985, refer comment 8.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.