Skip to content

Fixes the warning if null is given to prepare_items_query() #7625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apermo wants to merge 7 commits into from
Closed

Fixes the warning if null is given to prepare_items_query() #7625

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a931a3f
fix(rest-api): handle null in prepare_items_query()
apermo Oct 23, 2024
36530f0
Type-check filter results at call-sites to avoid type errors.
dmsnell Feb 25, 2026
3081e87
Merge remote-tracking branch 'upstream/trunk' into HEAD
dmsnell Feb 25, 2026
35606cf
Account for value not being null (nor an array)
westonruter Feb 25, 2026
e54f258
Use conditional for ensuring args is array
westonruter Feb 25, 2026
15f956a
Fix incorrect placement of operator
westonruter Feb 25, 2026
765a1b5
Merge remote-tracking branch 'upstream/trunk' into fix-62287
dmsnell Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ static function ( $format ) {
* @param WP_REST_Request $request The REST API request.
*/
$args = apply_filters( "rest_{$this->post_type}_query", $args, $request );
$args = is_array( $args ) ? $args : array();
$query_args = $this->prepare_items_query( $args, $request );

$posts_query = new WP_Query();
Expand Down Expand Up @@ -1210,7 +1211,8 @@ public function delete_item( $request ) {
* @return array Items query arguments.
*/
protected function prepare_items_query( $prepared_args = array(), $request = null ) {
Comment thread
apermo marked this conversation as resolved.
$query_args = array();
$query_args = array();
$prepared_args = $prepared_args ?? array();

foreach ( $prepared_args as $key => $value ) {
/**
Expand Down
4 changes: 3 additions & 1 deletion src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ public function get_items( $request ) {

/** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php */
$args = apply_filters( 'rest_revision_query', $args, $request );
$args = is_array( $args ) ? $args : array();
$query_args = $this->prepare_items_query( $args, $request );

$revisions_query = new WP_Query();
Expand Down Expand Up @@ -548,7 +549,8 @@ public function delete_item( $request ) {
* @return array Items query arguments.
*/
protected function prepare_items_query( $prepared_args = array(), $request = null ) {
$query_args = array();
$query_args = array();
$prepared_args = $prepared_args ?? array();

foreach ( $prepared_args as $key => $value ) {
/** This filter is documented in wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php */
Expand Down
Loading