Skip to content

Improve optimisations of get_site_url #5054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
soderlind wants to merge 3 commits into from
Closed

Improve optimisations of get_site_url #5054

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e96965
See https://core.trac.wordpress.org/ticket/59173
soderlind Aug 23, 2023
ab088f2
Yoda I must
soderlind Aug 23, 2023
e221140
Remove backslash from function
soderlind Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/wp-includes/link-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3495,9 +3495,15 @@ function get_site_url( $blog_id = null, $path = '', $scheme = null ) {
if ( empty( $blog_id ) || ! is_multisite() ) {
$url = get_option( 'siteurl' );
} else {
switch_to_blog( $blog_id );
$url = get_option( 'siteurl' );
restore_current_blog();
// Use WP_Site_Query to get the site URL.
$site = get_site( $blog_id );

$url = $site->domain . $site->path;

// If the network has a custom domain, use that instead.
if ( \get_network()->domain !== $site->domain ) {
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why \ use here? Code did not use it in any code references

Copy link
Copy Markdown
Author

@soderlind soderlind Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. It's in my fingers, add them automatically because I always use namespace. I'll remove it i a few sec.

$url = get_network()->domain . $site->path;
}
}

$url = set_url_scheme( $url, $scheme );
Expand Down