Posts, Taxonomy: Skip wp_set_post_categories() on update when post_category is not provided#11698
Posts, Taxonomy: Skip wp_set_post_categories() on update when post_category is not provided#11698wppoland wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…_category` is not provided. `wp_insert_post()` always called `wp_set_post_categories()` on update, even when the caller did not pass `post_category`. The fallback then re-set the post's existing category list, which still goes through term-cache invalidation, term-relationship lookups, and counted toward the per-request query budget — a measurable regression for callers like REST API updates that change a single field. This commit gates that call on either (a) it being a new post or (b) `post_category` being explicitly set in the args. The `tags_input` and `tax_input` paths were already correctly guarded. Adds tests covering: * `set_object_terms` does not fire for the `category` taxonomy on a parameterless update. * Existing categories survive a parameterless update (regression guard). See #59354.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
1 participant
Trac ticket: https://core.trac.wordpress.org/ticket/59354
wp_insert_post()always calledwp_set_post_categories()on update, even when the caller did not passpost_category. The fallback then re-set the post's existing category list, which still goes through term-cache invalidation, term-relationship lookups, and counted toward the per-request query budget — a measurable regression for callers like REST API updates that change a single field.This PR gates that call on either (a) it being a new post or (b)
post_categorybeing explicitly set in the args. Thetags_inputandtax_inputpaths were already correctly guarded.Tests cover:
set_object_termsdoes not fire for thecategorytaxonomy on a parameterless updateThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.