REST API: Restore global $post in WP_REST_Posts_Controller::prepare_item_for_response()#11695
Open
wppoland wants to merge 1 commit intoWordPress:trunkfrom
Open
REST API: Restore global $post in WP_REST_Posts_Controller::prepare_item_for_response()#11695wppoland wants to merge 1 commit intoWordPress:trunkfrom
wppoland wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…prepare_item_for_response()`. Previously, this method overwrote `$GLOBALS['post']` and called `setup_postdata()` without restoring the previous state. Anything running after a REST request that re-used the controller (block rendering, the_content filters in subsequent calls, etc.) saw the wrong global post. This commit captures the previous global before mutation and restores it on every return path, including the early HEAD-request return. Adds tests covering: * Restoration when a global post is already set. * Restoration to `null` when no global post was set. * Restoration on the HEAD-method early-return branch. Complements WordPressGH-1165 and WordPressGH-11455. See #43502.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/43502
prepare_item_for_response()overwrote$GLOBALS['post']and calledsetup_postdata()without restoring the previous state. Anything running after a REST request that re-used the controller (block rendering,the_contentfilters, etc.) saw the wrong global post.This PR captures the previous global before mutation and restores it on every return path, including the early HEAD-request return.
Tests cover:
nullwhen no global post was setComplements GH-1165 and GH-11455.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.