Add check for post existence in admin bar#11644
Add check for post existence in admin bar#11644GautamMKGarg wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
apermo
left a comment
There was a problem hiding this comment.
LGTM, I also checked if any of the conditions might be cheaper for optimization, but the chosen order is already optimal.
|
thanks @apermo for approving the code. What is the next step? Do I need to do anything or the code with be merged automatically? |
|
A core committer will have a final review and either point out something they find or merge. |
GautamMKGarg
left a comment
There was a problem hiding this comment.
Steps to replicate the issue was provided at https://core.trac.wordpress.org/ticket/65128#comment:5
2 testers were able to replicate the issue and tested the patch
https://core.trac.wordpress.org/ticket/65128#comment:6
https://core.trac.wordpress.org/ticket/65128#comment:7
Patch for https://core.trac.wordpress.org/ticket/65128
Trac ticket: https://core.trac.wordpress.org/ticket/65128
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.