oEmbed: Fix PHP warnings when a registered provider is malformed

src/wp-includes/class-wp-oembed.php

@@ -273,6 +273,14 @@ public function get_provider( $url, $args = '' ) {
 		}
 
 		foreach ( $this->providers as $matchmask => $data ) {
+			if (
+				! is_array( $data ) ||
+				count( $data ) < 2 ||
+				! array_key_exists( 0, $data ) ||
+				! array_key_exists( 1, $data )
+			) {
+				continue;
+			}
 			list( $providerurl, $regex ) = $data;
 
 			// Turn the asterisk-type provider URLs into regex.

tests/phpunit/tests/oembed/wpOembed.php

@@ -276,4 +276,34 @@ public function test_wp_filter_pre_oembed_result_multisite_restores_state_if_no_
 		$this->assertFalse( $actual );
 		$this->assertSame( $current_blog_id, get_current_blog_id() );
 	}
+
+	/**
+	 * @ticket 65068
+	 *
+	 * @covers ::get_provider
+	 */
+	public function test_get_provider_skips_malformed_provider_entries() {
+		$warnings = array();
+
+		$error_handler = function ( $errno, $errstr ) use ( &$warnings ) {
+			if ( E_WARNING === $errno ) {
+				$warnings[] = $errstr;
+			}
+			return false;
+		};
+
+		set_error_handler( $error_handler );
+
+		$this->oembed->providers['bad_provider'] = array(
+			'url'      => '#https?://example\.site/.*#i',
+			'endpoint' => 'https://example.site/api/oembed',
+		);
+
+		$result = $this->oembed->get_provider( 'https://en.wikipedia.org/wiki/Rickrolling' );
+
+		restore_error_handler();
+
+		$this->assertFalse( $result );
+		$this->assertSame( array(), $warnings, 'PHP warnings were raised: ' . implode( ', ', $warnings ) );
+	}
 }