-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add metabox flag for RTC-compatible metaboxes #11566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alecgeatches
wants to merge
6
commits into
WordPress:trunk
Choose a base branch
from
alecgeatches:backport/rtc-compatible-metabox-meta
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−2
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
13c5310
Use `__rtc_compatible_meta_box` flag to set RTC-compatible metaboxes
alecgeatches 7cf2453
Merge refactor from gutenberg#77361
alecgeatches 2135338
Merge branch 'trunk' into backport/rtc-compatible-metabox-meta
alecgeatches 5592160
Minor metabox flag refactor
alecgeatches 108c97c
Merge branch 'backport/rtc-compatible-metabox-meta' of github.com:ale…
alecgeatches d71872c
Merge branch 'trunk' into backport/rtc-compatible-metabox-meta
alecgeatches File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also keep the old code and always pass the boolean value. On the client, missing
__rtc_compatibleis evaluated as false.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Simplified in 5592160.