Skip to content

Nonce check order flaw in post-quickdraft-save #11539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajeshcpr wants to merge 5 commits into
base: trunk
Choose a base branch
from
+11 −3
Open

Nonce check order flaw in post-quickdraft-save #11539

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6821ef
Nonce check order flaw in post-quickdraft-save
rajeshcpr Apr 9, 2026
79856df
Merge branch 'trunk' into rajeshcpr-patch-4
rajeshcpr Apr 10, 2026
cf9e3db
Update post.php
rajeshcpr Apr 10, 2026
b5702d5
Update post.php
rajeshcpr Apr 10, 2026
dc9fb3c
Merge branch 'trunk' into rajeshcpr-patch-4
rajeshcpr Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/wp-admin/post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,14 @@
switch ( $action ) {
case 'post-quickdraft-save':
// Check nonce and capabilities.
$nonce = $_REQUEST['_wpnonce'];
$nonce = isset( $_REQUEST['_wpnonce'] ) ? $_REQUEST['_wpnonce'] : '';
Copy link
Copy Markdown
Member

@westonruter westonruter Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$nonce = isset( $_REQUEST['_wpnonce'] ) ? $_REQUEST['_wpnonce'] : '';
$nonce = $_REQUEST['_wpnonce'] ?? '';

$post_id = absint( $_REQUEST['post_ID'] ?? 0 );
$error_msg = false;

// For output of the Quick Draft dashboard widget.
require_once ABSPATH . 'wp-admin/includes/dashboard.php';

if ( ! wp_verify_nonce( $nonce, 'add-post' ) ) {
if ( ! $post_id || ! wp_verify_nonce( $nonce, 'add-post' ) ) {
Copy link
Copy Markdown
Member

@westonruter westonruter Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively:

Suggested change
if ( ! $post_id || ! wp_verify_nonce( $nonce, 'add-post' ) ) {
if ( ! $post_id || ! check_ajax_referer( 'add-post', false, false ) ) {

This would eliminate the need for the $nonce variable entirely.

$error_msg = __( 'Unable to submit this form, please refresh and try again.' );
}

Expand All @@ -90,7 +91,14 @@
return wp_dashboard_quick_press( $error_msg );
}

$post = get_post( $_REQUEST['post_ID'] );
$post = get_post( $post_id );
if ( ! $post ) {
$error_msg = __( 'Unable to submit this form, please refresh and try again.' );
}

if ( $error_msg ) {
return wp_dashboard_quick_press( $error_msg );
}
check_admin_referer( 'add-' . $post->post_type );

$_POST['comment_status'] = get_default_comment_status( $post->post_type );
Expand Down
Loading