Skip to content

Media: Update post mime type when image format is converted during upload#11261

Closed
adamsilverstein wants to merge 1 commit intoWordPress:trunkfrom
adamsilverstein:fix/heic-upload
Closed

Media: Update post mime type when image format is converted during upload#11261
adamsilverstein wants to merge 1 commit intoWordPress:trunkfrom
adamsilverstein:fix/heic-upload

Conversation

@adamsilverstein
Copy link
Copy Markdown
Member

Summary

  • Updates _wp_image_meta_replace_original() to also update the attachment's post_mime_type when the image is converted to a different format (e.g., HEIC to JPEG). Previously, the actual files on disk were correctly converted but the post's mime type remained unchanged.
  • Fixes the REST API index to use wp_get_image_editor_output_format() when building image_output_formats, so the default HEIC-to-JPEG mapping is properly exposed to client-side media processing.

Trac ticket

https://core.trac.wordpress.org/ticket/XXXXX (to be created)

Test plan

  • Upload a HEIC file via the media library (not using client-side media processing in the block editor) on a server with HEIC support (e.g., Imagick with HEIC support)
  • Verify the attachment's mime type is image/jpeg after upload, not image/heic
  • Verify the generated sub-sizes are JPEG files
  • Verify the REST API index (/wp-json/) includes image/heic: image/jpeg in image_output_formats when client-side media processing is enabled
  • Upload a regular JPEG/PNG to confirm no regressions in the normal upload flow

🤖 Generated with Claude Code

…load.

When uploading HEIC files via the media library on servers that support
HEIC, the image is correctly converted to JPEG on disk but the
attachment post's `post_mime_type` remained `image/heic`. This updates
`_wp_image_meta_replace_original()` to also update the post mime type
when the saved image format differs from the original.

Additionally fixes the REST API index to use `wp_get_image_editor_output_format()`
so the `image_output_formats` response includes the default HEIC-to-JPEG
mapping, enabling client-side media processing to be aware of it.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
@github-actions
Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props adamsilverstein.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@adamsilverstein adamsilverstein marked this pull request as draft March 15, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant