Skip to content

Fixes #64825: Twenty Seventeen: Stop passing get_the_ID() to twentyseventeen_edit_link(), simplify docblock. #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PANawkar wants to merge 2 commits into from
Closed

Fixes #64825: Twenty Seventeen: Stop passing get_the_ID() to twentyseventeen_edit_link(), simplify docblock. #11209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a293a77
Stop passing get_the_ID() to twentyseventeen_edit_link()
Mar 9, 2026
5948b22
Apply suggestions from code review
PANawkar Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/wp-content/themes/twentyseventeen/inc/template-tags.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,7 @@ function twentyseventeen_entry_footer() {

if ( ! function_exists( 'twentyseventeen_edit_link' ) ) :
/**
* Returns an accessibility-friendly link to edit a post or page.
*
* This also gives a little context about what exactly we're editing
* (post or page?) so that users understand a bit more where they are in terms
* of the template hierarchy and their content. Helpful when/if the single-page
* layout with multiple posts/pages shown gets confusing.
Comment on lines -113 to -118
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be reverted

Copy link
Copy Markdown

@sabernhardt sabernhardt Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation update is more important than a PHPStan-related change. The function does not give any page/post context since that was removed in PR 89, before version 1.0.

* Displays an accessibility-friendly edit link for the current post in the loop.
Comment thread
PANawkar marked this conversation as resolved.
Outdated
*/
function twentyseventeen_edit_link() {
edit_post_link(
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyseventeen/template-parts/page/content-front-page-panels.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<header class="entry-header">
<?php the_title( '<h2 class="entry-title">', '</h2>' ); ?>

<?php twentyseventeen_edit_link( get_the_ID() ); ?>
<?php twentyseventeen_edit_link(); ?>

</header><!-- .entry-header -->

Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyseventeen/template-parts/page/content-front-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<header class="entry-header">
<?php the_title( '<h2 class="entry-title">', '</h2>' ); ?>

<?php twentyseventeen_edit_link( get_the_ID() ); ?>
<?php twentyseventeen_edit_link(); ?>

</header><!-- .entry-header -->

Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentyseventeen/template-parts/page/content-page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
<header class="entry-header">
<?php the_title( '<h1 class="entry-title">', '</h1>' ); ?>
<?php twentyseventeen_edit_link( get_the_ID() ); ?>
<?php twentyseventeen_edit_link(); ?>
</header><!-- .entry-header -->
<div class="entry-content">
<?php
Expand Down
Loading