Skip to content

Add property_exists check for object field access #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GautamMKGarg wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Add property_exists check for object field access #11115

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c76e0f
Add property_exists check for object field access
GautamMKGarg Mar 2, 2026
9c4ece0
Formatting fixed
GautamMKGarg Mar 2, 2026
c495670
Merge branch 'trunk' into patch-1
GautamMKGarg Mar 2, 2026
91716f7
Apply suggestion from @westonruter
GautamMKGarg Mar 3, 2026
31a6386
Apply suggestion from @westonruter
GautamMKGarg Mar 3, 2026
a391d35
Merge branch 'trunk' into patch-1
GautamMKGarg Mar 3, 2026
4d9d00d
Merge branch 'trunk' into patch-1
GautamMKGarg Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wp-includes/class-wp-list-util.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ public function pluck( $field, $index_key = null ) {
*/
foreach ( $this->output as $key => $value ) {
if ( is_object( $value ) ) {
$newlist[ $key ] = $value->$field;
if ( property_exists( $value, $field ) ) {
Copy link
Copy Markdown
Member

@mukeshpanchal27 mukeshpanchal27 Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let'e combine the conditions.

if ( is_object( $value ) && property_exists( $value, $field ) ) {

Copy link
Copy Markdown
Member

@westonruter westonruter Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, because it will then fall through to the else case and the user will get a message “Values for the input array must be either objects or arrays.” This will be confusing because the value is indeed an object, but just it doesn't have the property.

Copy link
Copy Markdown
Author

@GautamMKGarg GautamMKGarg Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27
I was thinking of this solution earlier, but due to the reason which @westonruter mentioned, I had chosen nested if.

$newlist[ $key ] = $value->$field;
}
Comment thread
GautamMKGarg marked this conversation as resolved.
Outdated
} elseif ( is_array( $value ) ) {
$newlist[ $key ] = $value[ $field ];
Comment thread
GautamMKGarg marked this conversation as resolved.
Outdated
} else {
Expand Down
Loading