Skip to content

Set the default background for notice-info to white#11033

Closed
joedolson wants to merge 5 commits intoWordPress:trunkfrom
joedolson:change-notice-info-background
Closed

Set the default background for notice-info to white#11033
joedolson wants to merge 5 commits intoWordPress:trunkfrom
joedolson:change-notice-info-background

Conversation

@joedolson
Copy link
Copy Markdown
Contributor

Changes the core notice info to have a white background.

This doesn't match the Gutenberg design specs, but because WordPress uses a gray background, it's not actually possible to meet those specs 100%, and this will be a less disruptive change for users.

Trac ticket: https://core.trac.wordpress.org/ticket/64678

Use of AI Tools

none


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 24, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joedolson, peterwilsoncc, pbiron.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Copy Markdown
Contributor

@joedolson I've taken the liberty of pushing the same change to login.css to apply the background during the password reset flow, etc.

Screenshot 2026-02-25 at 1 14 01 pm

Copy link
Copy Markdown
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with Joe's changes if Joe is happy with mine.

I did a search for other instances of the string .notice searching for overrides in (S)CSS files and was unable to find one.

Comment thread src/wp-admin/css/common.css
Comment thread src/wp-admin/css/login.css
Comment thread src/wp-admin/css/common.css
@github-actions
Copy link
Copy Markdown

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 61737
GitHub commit: 17d91f6

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

@github-actions github-actions Bot closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants